Merge branch 'development' into f-RedesignICFG

Author: fabianbs96

.clang-tidy

@@ -15,7 +15,6 @@ Checks: '-*,
            -readability-function-cognitive-complexity,
            -readability-convert-member-functions-to-static,
            -readability-isolate-declaration,
-           -readability-identifier-length,
          cppcoreguidelines-*,
            -cppcoreguidelines-avoid-non-const-global-variables,
            -cppcoreguidelines-pro-bounds-array-to-pointer-decay,

.docker/Dockerfile.devenv

@@ -16,4 +16,5 @@ USER vscode
 
 ENV CC "/usr/bin/clang-14"
 ENV CXX "/usr/bin/clang++-14"
+ENV PATH "/usr/local/llvm-14/bin:/home/vscode/.local/bin:$PATH"
 ENV CMAKE_GENERATOR "Ninja"

.github/workflows/docker.yml

@@ -0,0 +1,50 @@
+name: Docker Image
+
+on:
+  push:
+    branches: [ development ]
+
+jobs:
+  push_to_registries:
+    name: Push Docker image to multiple registries
+    runs-on: ubuntu-latest
+    permissions:
+      packages: write
+      contents: read
+    steps:
+      - name: Check out the repo
+        uses: actions/checkout@v3
+      - name: Set up QEMU
+        uses: docker/setup-qemu-action@v2
+      - name: Set up Docker Buildx
+        uses: docker/setup-buildx-action@v2
+      # If we want to publish an image of PhASAR to the official docker hub we
+      # can just use the following code and set the corresponding secrets.
+      # - name: Log in to Docker Hub
+      #   uses: docker/login-action@f054a8b539a109f9f41c372932f1ae047eff08c9
+      #   with:
+      #     username: ${{ secrets.DOCKER_USERNAME }}
+      #     password: ${{ secrets.DOCKER_TOKEN }}
+
+      - name: Log in to the Container registry
+        uses: docker/login-action@v2
+        with:
+          registry: ghcr.io
+          username: ${{ github.actor }}
+          password: ${{ secrets.GITHUB_TOKEN }}
+
+      - name: Extract metadata (tags, labels) for Docker
+        id: meta
+        uses: docker/metadata-action@v4
+        with:
+          images: ghcr.io/${{ github.repository }}
+            # here we could add a second image for the official docker registry
+            # sse/phasar
+      - name: Build and push Docker images
+        uses: docker/build-push-action@v3
+        with:
+          context: .
+          platforms: linux/amd64,linux/arm64
+          push: true
+          tags: ${{ steps.meta.outputs.tags }}
+          labels: ${{ steps.meta.outputs.labels }}

.gitmodules

@@ -6,9 +6,6 @@
 	path = external/googletest
 	url = https://github.com/google/googletest.git
 	branch = master
-[submodule "external/WALi-OpenNWA"]
-	path = external/WALi-OpenNWA
-	url = https://github.com/pdschubert/WALi-OpenNWA.git
 [submodule "external/json-schema-validator"]
 	path = external/json-schema-validator
 	url = https://github.com/pboettch/json-schema-validator.git

CMakeLists.txt

@@ -31,7 +31,7 @@ elseif(CMAKE_BUILD_TYPE STREQUAL "Debug")
   set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -MP -fvisibility-inlines-hidden -fstack-protector-strong -ffunction-sections -fdata-sections -pipe -g")
 else()
   message(STATUS "Selected Release Build")
-  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -MP -fvisibility-inlines-hidden -fstack-protector-strong -ffunction-sections -fdata-sections -pipe -march=native")
+  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -MP -fvisibility-inlines-hidden -fstack-protector-strong -ffunction-sections -fdata-sections -pipe")
 endif()
 
 # Enable testing
@@ -243,10 +243,6 @@ if (PHASAR_IN_TREE)
   )
 endif()
 
-# WALi-OpenNWA
-add_subdirectory(external/WALi-OpenNWA)
-include_directories(external/WALi-OpenNWA/Source/wali/include)
-
 # Set up clang-tidy to run during PhASAR's compilation to indicate code smells
 if (PHASAR_ENABLE_CLANG_TIDY_DURING_BUILD)
   message(STATUS "Enabled clang-tidy during build")

Dockerfile

@@ -1,44 +1,61 @@
-FROM ubuntu:20.04
-ARG LLVM_INSTALL_DIR="/usr/local/llvm-12"
+FROM ubuntu:22.04
+ARG LLVM_INSTALL_DIR="/usr/local/llvm-14"
 LABEL Name=phasar Version=1.0.0
 
 RUN apt -y update && apt install bash sudo -y
 
+
 WORKDIR /usr/src/phasar
 RUN mkdir -p /usr/src/phasar/utils
 
 COPY ./utils/InitializeEnvironment.sh /usr/src/phasar/utils/
 RUN ./utils/InitializeEnvironment.sh
 
+RUN apt-get -y install --no-install-recommends \
+    cmake \
+    ninja-build \
+    libstdc++6 \
+    libboost-all-dev
+
 COPY ./utils/InstallAptDependencies.sh /usr/src/phasar/utils/
 RUN ./utils/InstallAptDependencies.sh
 
+RUN apt-get update && \
+    apt-get install -y software-properties-common
+
+RUN apt-key adv --fetch-keys https://apt.llvm.org/llvm-snapshot.gpg.key && \
+           add-apt-repository -y 'deb http://apt.llvm.org/focal/ llvm-toolchain-focal-14 main' && \
+           apt-get update && \
+           apt-get -y install --no-install-recommends \
+              clang-14 \
+              llvm-14-dev \
+              libllvm14 \
+              libclang-common-14-dev \
+              libclang-14-dev \
+              libclang-cpp14-dev \
+              clang-tidy-14
+
 RUN pip3 install Pygments pyyaml
 
 # installing boost
 RUN apt install libboost-all-dev -y
 
-# installing LLVM
-COPY utils/safeCommandsSet.sh /usr/src/phasar/utils/safeCommandsSet.sh
-COPY utils/install-llvm.sh /usr/src/phasar/utils/install-llvm.sh
-RUN ./utils/install-llvm.sh $(nproc) . ${LLVM_INSTALL_DIR} "llvmorg-12.0.0"
 
 # installing wllvm
 RUN pip3 install wllvm
 
-ENV CC=${LLVM_INSTALL_DIR}/bin/clang
-ENV CXX=${LLVM_INSTALL_DIR}/bin/clang++
-ENV LD_LIBRARY_PATH=${LLVM_INSTALL_DIR}/lib:$LD_LIBRARY_PATH
+ENV CC=/usr/bin/clang-14
+ENV CXX=/usr/bin/clang++-14
 
 COPY . /usr/src/phasar
 
 RUN git submodule init
 RUN git submodule update
-RUN mkdir -p build &&                       \
-    cd build &&                             \
-    cmake -DCMAKE_BUILD_TYPE=Release .. &&  \
-    make -j $(nproc) &&                     \
-    make install &&                         \
-    ldconfig
+RUN mkdir -p build && cd build && \
+          cmake .. \
+            -DCMAKE_BUILD_TYPE=Release \
+            -DCMAKE_CXX_COMPILER=$CXX \
+            -G Ninja && \
+          cmake --build .
 
 ENTRYPOINT [ "./build/tools/phasar-llvm/phasar-llvm" ]

LICENSE.txt

@@ -99,36 +99,6 @@ pyyaml tests        llvm/test/YAMLParser/{*.data, LICENSE.TXT}
 ARM contributions   llvm/lib/Target/ARM/LICENSE.TXT
 md5 contributions   llvm/lib/Support/MD5.cpp llvm/include/llvm/Support/MD5.h
 
-
-WALi-OpenNWA
--------------------------------------------------------------------------------
-OpenNWA portions:
-  Copyright (c) 2009-2012 Amanda Burton, Evan Driscoll, Aditya Thakur,
-                and Thomas Reps
-
-WALi portions:
-  Copyright (c) 2010 Nicholas Kidd, Akash Lal, and Thomas Reps
-  Copyright (c) 2007 Nicholas Kidd, Akash Lal, and Thomas Reps
-
-Permission is hereby granted, free of charge, to any person obtaining a copy
-of this software and associated documentation files (the "Software"), to deal
-in the Software without restriction, including without limitation the rights
-to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-copies of the Software, and to permit persons to whom the Software is
-furnished to do so, subject to the following conditions:
-
-The above copyright notice and this permission notice shall be included in
-all copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
-THE SOFTWARE.
-
-
 Boost
 -------------------------------------------------------------------------------
 Boost Software License - Version 1.0 - August 17th, 2003

external/WALi-OpenNWA

@@ -49,7 +49,7 @@ enum class AnalysisControllerEmitterOptions : uint32_t {
   EmitPTAAsText = (1 << 11),
   EmitPTAAsDot = (1 << 12),
   EmitPTAAsJson = (1 << 13),
-  EmitStatisticAsJson = (1 << 14),
+  EmitStatisticsAsJson = (1 << 14),
 };
 
 class AnalysisController {

include/phasar/Controller/AnalysisController.h

@@ -120,7 +120,7 @@ class AllTop : public EdgeFunction<L>,
   const L TopElement;
 
 public:
-  AllTop(const L TopElement) : TopElement(std::move(TopElement)) {}
+  AllTop(L TopElement) : TopElement(std::move(TopElement)) {}
 
   ~AllTop() override = default;
 
@@ -161,33 +161,18 @@ class AllBottom : public EdgeFunction<L>,
   const L BottomElement;
 
 public:
-  AllBottom(const L BottomElement) : BottomElement(std::move(BottomElement)) {}
+  AllBottom(L BottomElement) : BottomElement(std::move(BottomElement)) {}
 
   ~AllBottom() override = default;
 
   L computeTarget(L /*Source*/) override { return BottomElement; }
 
-  EdgeFunctionPtrType composeWith(EdgeFunctionPtrType SecondFunction) override {
-    if (auto *AB = dynamic_cast<AllBottom<L> *>(SecondFunction.get())) {
-      return this->shared_from_this();
-    }
-    if (auto *EI = dynamic_cast<EdgeIdentity<L> *>(SecondFunction.get())) {
-      return this->shared_from_this();
-    }
-    return SecondFunction->composeWith(this->shared_from_this());
+  EdgeFunctionPtrType
+  composeWith(EdgeFunctionPtrType /*SecondFunction*/) override {
+    return this->shared_from_this();
   }
 
-  EdgeFunctionPtrType joinWith(EdgeFunctionPtrType OtherFunction) override {
-    if (OtherFunction.get() == this ||
-        OtherFunction->equal_to(this->shared_from_this())) {
-      return this->shared_from_this();
-    }
-    if (auto *Alltop = dynamic_cast<AllTop<L> *>(OtherFunction.get())) {
-      return this->shared_from_this();
-    }
-    if (auto *EI = dynamic_cast<EdgeIdentity<L> *>(OtherFunction.get())) {
-      return this->shared_from_this();
-    }
+  EdgeFunctionPtrType joinWith(EdgeFunctionPtrType /*OtherFunction*/) override {
     return this->shared_from_this();
   }