Various fixes (debug macro, linked)

Fixes debug macro declaraion
Fixes debug macro usages
Fixes thread linking for controller and phasar pass

Author: vulder

include/phasar/PhasarLLVM/DataFlowSolver/IfdsIde/FlowEdgeFunctionCache.h

@@ -283,7 +283,7 @@ class FlowEdgeFunctionCache {
         PHASAR_LOG_LEVEL(DEBUG, "(F) Callee's  : "); for (auto callee
                                                           : Callees) {
           PHASAR_LOG_LEVEL(DEBUG, "  " << Problem.FtoString(callee));
-        };)
+        });
     auto Key = std::tie(CallSite, RetSite, Callees);
     auto SearchCallToRetFlowFunction = CallToRetFlowFunctionCache.find(Key);
     if (SearchCallToRetFlowFunction != CallToRetFlowFunctionCache.end()) {

include/phasar/Utils/Logger.h

@@ -91,6 +91,9 @@ class Logger final {
       const std::variant<StdStream, std::string> &StreamVariant);
 };
 
+#define IF_LOG_ENABLED(computation)                                            \
+  IF_LOG_ENABLED_BOOL(Logger::isLoggingEnabled(), computation)
+
 #ifdef DYNAMIC_LOG
 
 #define PHASAR_LOG(message) PHASAR_LOG_LEVEL(DEBUG, message)
@@ -136,12 +139,6 @@ class Logger final {
     computation;                                                               \
   }
 
-// #define LOG_IF_ENABLE(computation)                                          \
-//   IF_LOG_ENABLED_BOOL(Logger::isLoggingEnabled(), computation)
-
-#define IF_LOG_ENABLED(computation)                                            \
-  IF_LOG_ENABLED_BOOL(Logger::isLoggingEnabled(), computation)
-
 #define IS_LOG_ENABLED Logger::isLoggingEnabled()
 
 #else

lib/Controller/CMakeLists.txt

@@ -32,6 +32,7 @@ endif()
 target_link_libraries(phasar_controller
   LINK_PUBLIC
   curl
+  ${CMAKE_THREAD_LIBS_INIT}
   ${PHASAR_STD_FILESYSTEM}
 )
 

lib/PhasarLLVM/Passes/GeneralStatisticsAnalysis.cpp

@@ -177,7 +177,7 @@ GeneralStatisticsAnalysis::run(llvm::Module &M,
         llvm::raw_string_ostream Rso(TypeStr);
         Type->print(Rso);
         PHASAR_LOG_LEVEL(INFO, "  " << Rso.str());
-      })
+      });
   // now we are done and can return the results
   return Stats;
 }

lib/PhasarLLVM/TypeHierarchy/CMakeLists.txt

@@ -6,6 +6,7 @@ set(PHASAR_LINK_LIBS
 
 set(LLVM_LINK_COMPONENTS
   Core
+  Demangle
   Support
   Analysis
 )

lib/PhasarPass/CMakeLists.txt

@@ -36,6 +36,7 @@ endif()
 find_package(Boost COMPONENTS graph program_options REQUIRED)
 target_link_libraries(phasar_pass
   LINK_PUBLIC
+  ${CMAKE_THREAD_LIBS_INIT}
   ${PHASAR_LINK_LIBS}
   ${Boost_LIBRARIES}
 )