From abda5502b5b245d7402170d0162df4ba396f11ed Mon Sep 17 00:00:00 2001 From: Muskan Hashim Date: Thu, 27 Aug 2026 15:12:50 +0200 Subject: [PATCH] Fix the join page icons The icon class was concatenated onto card-title with no separator, so every card rendered class="card-titlebi-github" and neither class applied. That is why the page shows no icons, and why the X card looks empty: its label comes entirely from .i-xcom::before, with title deliberately blank. Adding a space does not survive CI - prettier-plugin-go-template collapses whitespace between template actions in an attribute, which is what reverted #282 and left that merge empty. The icon class now sits on its own span, so there is no combined attribute to format. --- layouts/join/list.html | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/layouts/join/list.html b/layouts/join/list.html index 0c1efc4..2c6690a 100644 --- a/layouts/join/list.html +++ b/layouts/join/list.html @@ -8,9 +8,12 @@

{{ .Title }}

- {{/* Icon class travels with the entry, so a new channel is a content change */}} -
- {{ with $item.icon }} {{ end }}{{ $item.title }} + {{/* Icon class travels with the entry, so a new channel is a content change. + It sits on its own span rather than on the heading: prettier collapses the space + a combined `class="card-title …"` would need. + */}} +
+ {{ with $item.icon }} {{ end }}{{ $item.title }}

{{ $item.text }}