Skip to content

Commit 082b13f

Browse files
committed
some improvements
1 parent 2055636 commit 082b13f

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

src/git.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,7 @@ hint: See the 'Note about fast-forwards' in 'git push --help' for details.
220220
```
221221

222222
The advice this gives is incorrect!
223-
Because of Rust's ["no-merge" policy](#no-merge-policy) the merge commit created by `git pull`
223+
Because of Rust's ["no-merge" policy](#no-merge-policy), the merge commit created by `git pull`
224224
will not be allowed in the final PR, in addition to defeating the point of the rebase!
225225
Use `git push --force-with-lease` instead.
226226

@@ -280,7 +280,7 @@ out if you're using `download-ci-llvm`.
280280

281281
When you edit your code locally, you are making changes to the version of
282282
rust-lang/rust that existed when you created your feature branch.
283-
As such, when you submit your PR it is possible that some of the changes that have been made
283+
As such, when you submit your PR, it is possible that some of the changes that have been made
284284
to rust-lang/rust since then are in conflict with the changes you've made.
285285
When this happens, you need to resolve the conflicts before your changes can be merged.
286286
To do that, you need to rebase your work on top of rust-lang/rust.
@@ -309,7 +309,7 @@ In other words, Git tries to
309309
pretend that the changes you made to the old version of `main` were instead
310310
made to the new version of `main`.
311311
During this process, you should expect to
312-
encounter at least one "rebase conflict." This happens when Git's attempt to
312+
encounter at least one "rebase conflict". This happens when Git's attempt to
313313
reapply the changes fails because your changes conflicted with other changes that have been made.
314314
You can tell that this happened because you'll see lines in the output that look like
315315
@@ -472,7 +472,7 @@ command useful, especially their ["Examples" section][range-diff-example-docs].
472472

473473
## No-Merge Policy
474474

475-
The rust-lang/rust repo uses what is known as a "rebase workflow." This means
475+
The rust-lang/rust repo uses what is known as a "rebase workflow". This means
476476
that merge commits in PRs are not accepted.
477477
As a result, if you are running
478478
`git merge` locally, chances are good that you should be rebasing instead.
@@ -483,7 +483,7 @@ Running `git config merge.ff only` (this will apply the config to the local repo
483483
once will ensure that all the merges you perform are of this type, so that you
484484
cannot make a mistake.
485485

486-
There are a number of reasons for this decision and like all others, it is a tradeoff.
486+
There are a number of reasons for this decision, and like all others, it is a tradeoff.
487487
The main advantage is the generally linear commit history.
488488
This greatly simplifies bisecting and makes the history and commit log much easier
489489
to follow and understand.
@@ -560,7 +560,7 @@ you might want to get used to the main concepts of Git before reading this secti
560560
The `rust-lang/rust` repository uses [Git submodules] as a way to use other
561561
Rust projects from within the `rust` repo.
562562
Examples include Rust's fork of
563-
`llvm-project`, `cargo` and libraries like `stdarch` and `backtrace`.
563+
`llvm-project`, `cargo`, and libraries like `stdarch` and `backtrace`.
564564

565565
Those projects are developed and maintained in an separate Git (and GitHub)
566566
repository, and they have their own Git history/commits, issue tracker and PRs.

0 commit comments

Comments
 (0)