Rename Hash#to_proc to setter, consolidate arrange/to_ranges

- Rename Hash#to_proc to Hash#setter to avoid clash with Ruby's
  Hash#to_proc (key lookup vs attribute assignment)
- Fix bug in setter where respond_to? checked self instead of receiver
- Consolidate Array#arrange and Array#to_ranges; to_ranges is now
  primary with arrange/rangify as aliases
- to_ranges now handles mixed ranges and values, and compacts nils

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: trans

HISTORY.md

@@ -17,6 +17,10 @@ Changes:
   * Add `Binding#caller_locations`.
   * Add `Kernel#tee` — block-less method chaining via Tee/Functor, replaces `tap` override.
   * Add `Tee` as alias for `Functor` (gradual rename).
+  * Rename `Hash#to_proc` to `Hash#setter` (avoids clash with Ruby 2.3's `Hash#to_proc`
+    which does key lookup; Facets' version does attribute assignment).
+  * Consolidate `Array#arrange` and `Array#to_ranges`; `to_ranges` is now primary,
+    `arrange` and `rangify` are aliases. Now handles mixed ranges and values.
 
 * Improved Features
 

lib/core/facets/array/arrange.rb

@@ -1,42 +1 @@
-class Array
-
-  # The `arrange` method produces appropriate ranges from the objects in the array.
-  #
-  # Examples
-  #
-  #     [1,2,3,6,7,8].arrange  #=> [1..3, 6..8]
-  #
-  #     [10..15, 16..20, 21, 22].arrange  #=> [10..22]
-  #
-  # Assumes inclusive ranges (ie. 1..4) and range.first <= range.last.
-  #
-  # Works with integers, dates and strings. However, all the objects in the array must
-  # be of the same class.
-  #
-  # CREDIT: monocle
-
-  def arrange
-		array = uniq.sort_by { |e| Range === e ? e.first : e }
-		array.inject([]) do |c, value|
-			unless c.empty?
-				last = c.last
-				last_value    = (Range === last  ? last.last   : last)
-				current_value = (Range === value ? value.first : value)
-				if (last_value.succ <=> current_value) == -1
-					c << value
-				else
-					first  = (Range === last ? last.first : last)
-					second = [Range === last ? last.last : last, Range === value ? value.last : value].max
-					c[-1] = [first..second]
-					c.flatten!
-				end
-			else
-				c << value
-			end
-		end
-	end
-
-  alias rangify arrange
-
-end
-
+require 'facets/array/to_ranges'

lib/core/facets/array/to_ranges.rb

@@ -1,30 +1,45 @@
 class Array
 
-  # Convert an array of values (which must respond to #succ) to an
-  # array of ranges.
+  # Produces an array of ranges from the values in the array.
+  # Contiguous values and overlapping ranges are merged.
   #
-  #   [3,4,5,1,6,9,8].to_ranges => [1..1,3..6,8..9]
+  # Examples
   #
-  # CREDIT: Adapted and debugged by Ryan Duryea
-  # from https://dzone.com/articles/convert-ruby-array-ranges
+  #     [1,2,3,6,7,8].to_ranges  #=> [1..3, 6..8]
+  #
+  #     [3,4,5,1,6,9,8].to_ranges  #=> [1..6, 8..9]
+  #
+  #     [10..15, 16..20, 21, 22].to_ranges  #=> [10..22]
+  #
+  # Assumes inclusive ranges (i.e. 1..4) and range.first <= range.last.
+  #
+  # Works with integers, dates and strings. However, all the objects
+  # in the array must be of the same class.
+  #
+  # CREDIT: monocle, Ryan Duryea
 
   def to_ranges
-    array = self.compact.uniq.sort
-    ranges = []
-    if !array.empty?
-      # Initialize the left and right endpoints of the range
-      left, right = array.first, nil
-      array.each do |obj|
-        # If the right endpoint is set and obj is not equal to right's successor
-        # then we need to create a range.
-        if right && obj != right.succ
-          ranges << Range.new(left,right)
-          left = obj
+    array = compact.uniq.sort_by { |e| Range === e ? e.first : e }
+    array.inject([]) do |c, value|
+      unless c.empty?
+        last = c.last
+        last_value    = (Range === last  ? last.last   : last)
+        current_value = (Range === value ? value.first : value)
+        if (last_value.succ <=> current_value) == -1
+          c << value
+        else
+          first  = (Range === last ? last.first : last)
+          second = [Range === last ? last.last : last, Range === value ? value.last : value].max
+          c[-1] = [first..second]
+          c.flatten!
         end
-        right = obj
+      else
+        c << value
       end
-      ranges << Range.new(left,right)
     end
-    ranges
   end
+
+  alias arrange to_ranges
+  alias rangify to_ranges
+
 end

lib/core/facets/hash/to_proc.rb lib/core/facets/hash/setter.rblib/core/facets/hash/to_proc.rb renamed to lib/core/facets/hash/setter.rb

@@ -1,28 +1,28 @@
 class Hash
 
-  # Constructs a Proc object from a hash such that the parameter
-  # of the Proc is assigned the hash keys as attributes.
+  # Constructs a Proc that assigns the hash's key-value pairs as
+  # attributes on a given object.
   #
   #   c = Class.new do
   #     attr_accessor :a
   #   end
   #
   #   h = {:a => 1}
   #   o = c.new
-  #   h.to_proc.call(o)
+  #   h.setter.call(o)
   #   o.a  #=> 1
   #
-  # If +response+ is set to +true+, then assignment will only occur
-  # if receiver responds_to? the writer method.
+  # If +safe+ is set to +true+, then assignment will only occur
+  # if the receiver responds_to? the writer method.
   #
   # CREDIT: Trans
 
-  def to_proc(response=false)
-    if response
+  def setter(safe=false)
+    if safe
       lambda do |o|
         self.each do |k,v|
           ke = "#{k}="
-          o.__send__(ke, v) if respond_to?(ke)
+          o.__send__(ke, v) if o.respond_to?(ke)
         end
       end
     else
@@ -36,4 +36,3 @@ def to_proc(response=false)
   end
 
 end
-

test/core/array/test_arrange.rb

@@ -1,4 +1,4 @@
-require 'facets/array/arrange'
+covers 'facets/array/arrange'
 
 test_case Array do
 

test/core/array/test_to_ranges.rb

@@ -4,10 +4,18 @@
 
   method :to_ranges do
 
-    test do
-      [3,4,5,1,6,9,8].to_ranges.assert ==  [1..1,3..6,8..9]
+    test "flat values" do
+      [3,4,5,1,6,9,8].to_ranges.assert == [1..1, 3..6, 8..9]
+    end
+
+    test "consecutive" do
+      [1,2,3,4,5].to_ranges.assert == [1..5]
+    end
+
+    test "mixed ranges and values" do
+      [10..15, 16..20, 21, 22].to_ranges.assert == [10..22]
     end
 
   end
-end
 
+end

test/core/hash/test_to_proc.rb test/core/hash/test_setter.rbtest/core/hash/test_to_proc.rb renamed to test/core/hash/test_setter.rb

@@ -1,8 +1,8 @@
-covers 'facets/hash/to_proc'
+covers 'facets/hash/setter'
 
 test_case Hash do
 
-  method :to_proc do
+  method :setter do
 
     test do
       c = Class.new do
@@ -12,12 +12,11 @@
       h = {:a => 1}
       o = c.new
 
-      h.to_proc.call(o)
+      h.setter.call(o)
 
       o.a.assert == 1
     end
 
   end
-  
-end
 
+end