chore: Change conditionals

Author: rubysoho07

layer/python/cloudtrail_watcher/services/airflow.py

@@ -9,7 +9,7 @@ def _set_mandatory_tag(event: dict):
     """ Set mandatory tag for MWAA(Managed Workflow for Apache Airflow) resources. """
 
     if 'Tags' in event['requestParameters'].keys():
-        if check_contain_mandatory_tag_dict(event['requestParameters']['tags']) is True:
+        if check_contain_mandatory_tag_dict(event['requestParameters']['tags']):
             return
 
     resource_arn = event['responseElements']['Arn']
@@ -24,7 +24,7 @@ def _set_mandatory_tag(event: dict):
 
 def _process_create_environment(event: dict, set_tag: bool = False) -> list:
 
-    if set_tag is True:
+    if set_tag:
         _set_mandatory_tag(event)
 
     return [event['requestParameters']['Name']]

layer/python/cloudtrail_watcher/services/cloudfront.py

@@ -11,12 +11,12 @@ def _process_create_distribution(event: dict, set_tag: bool = False) -> list:
 
     distribution_arn = event['responseElements']['distribution']['aRN']
 
-    if set_tag is True:
+    if set_tag:
         tags = cloudfront.list_tags_for_resource(Resource=distribution_arn)
 
         exists_mandatory_tag = check_contain_mandatory_tag_list(tags['Tags']['Items'])
 
-        if exists_mandatory_tag is False:
+        if not exists_mandatory_tag:
             cloudfront.tag_resource(Resource=distribution_arn,
                                     Tags={'Items': [{
                                         'Key': 'User',

layer/python/cloudtrail_watcher/services/dynamodb.py

@@ -19,15 +19,15 @@ def _process_create_table(event: dict, set_tag: bool = False) -> list:
 
     resource_ids = [event['responseElements']['tableDescription']['tableName']]
 
-    if set_tag is True:
+    if set_tag:
         has_user_tags = False
 
         # Check tags
         if 'tags' in event['requestParameters'].keys():
             has_user_tags = check_contain_mandatory_tag_list(event['requestParameters']['tags'])
 
         # If mandatory tags are not set, set mandatory tags
-        if has_user_tags is False:
+        if not has_user_tags:
             dynamodb.tag_resource(
                 ResourceArn=event['responseElements']['tableDescription']['tableArn'],
                 Tags=[{

layer/python/cloudtrail_watcher/services/ec2.py

@@ -32,7 +32,7 @@ def _process_run_instances(event: dict, set_tags: bool = False) -> list:
     resource_ids = _get_instance_resource_ids(event)
 
     # Set mandatory tags
-    if set_tags is True:
+    if set_tags:
         has_user_tag = {
             'instance': False,
             'volume': False,
@@ -50,10 +50,10 @@ def _process_run_instances(event: dict, set_tags: bool = False) -> list:
         for resource_id in resource_ids:
             instance = ec2.Instance(resource_id)
 
-            if has_user_tag['instance'] is False:
+            if not has_user_tag['instance']:
                 instance.create_tags(Tags=common_tags)
 
-            if has_user_tag['volume'] is False:
+            if not has_user_tag['volume']:
                 for volume in instance.volumes.all():
                     volume.create_tags(Tags=common_tags)
 
@@ -70,7 +70,7 @@ def _process_create_security_group(event: dict, set_tag: bool = False) -> list:
 
     sg = ec2.SecurityGroup(resource_ids[0])
 
-    if set_tag is True:
+    if set_tag:
         has_user_tags = False
 
         # Check tags
@@ -81,7 +81,7 @@ def _process_create_security_group(event: dict, set_tag: bool = False) -> list:
                     break
 
         # If mandatory tags are not set, set mandatory tags
-        if has_user_tags is False:
+        if not has_user_tags:
             sg.create_tags(Tags=[{
                 'Key': 'User',
                 'Value': get_user_identity(event)

layer/python/cloudtrail_watcher/services/ecr.py

@@ -10,12 +10,12 @@ def _process_create_repository(event: dict, set_tag: bool = False) -> list:
 
     repository_arn = event['responseElements']['repository']['repositoryArn']
 
-    if set_tag is True:
+    if set_tag:
         tags = ecr.list_tags_for_resource(resourceArn=repository_arn)
 
         exists_mandatory_tag = check_contain_mandatory_tag_list(tags['tags'])
 
-        if exists_mandatory_tag is False:
+        if not exists_mandatory_tag:
             ecr.tag_resource(resourceArn=repository_arn,
                              tags=[{
                                  'Key': 'User',

layer/python/cloudtrail_watcher/services/ecs.py

@@ -8,8 +8,8 @@
 def _process_create_cluster(event: dict, set_tag: bool = False) -> list:
     """ Process ECS CreateCluster API. """
 
-    if set_tag is True:
-        if check_contain_mandatory_tag_list(event['responseElements']['cluster']['tags']) is False:
+    if set_tag:
+        if not check_contain_mandatory_tag_list(event['responseElements']['cluster']['tags']):
             ecs.tag_resource(
                 resourceArn=event['responseElements']['cluster']['clusterArn'],
                 tags=[{

layer/python/cloudtrail_watcher/services/eks.py

@@ -8,8 +8,8 @@
 def _process_create_cluster(event: dict, set_tag: bool = False) -> list:
     """ Process ECS CreateCluster API. """
 
-    if set_tag is True:
-        if check_contain_mandatory_tag_dict(event['responseElements']['cluster']['tags']) is False:
+    if set_tag:
+        if not check_contain_mandatory_tag_dict(event['responseElements']['cluster']['tags']):
             eks.tag_resource(
                 resourceArn=event['responseElements']['cluster']['arn'],
                 tags={'User': get_user_identity(event)}

layer/python/cloudtrail_watcher/services/elasticache.py

@@ -9,7 +9,7 @@ def _set_mandatory_tag(event: dict):
     """ Set mandatory tag for ElastiCache resources. """
 
     if 'tags' in event['requestParameters'].keys():
-        if check_contain_mandatory_tag_list(event['requestParameters']['tags']) is True:
+        if check_contain_mandatory_tag_list(event['requestParameters']['tags']):
             return
 
     resource_id = event['responseElements']['aRN']
@@ -25,15 +25,15 @@ def _set_mandatory_tag(event: dict):
 
 def _process_create_cache_cluster(event: dict, set_tag: bool = False) -> list:
 
-    if set_tag is True:
+    if set_tag:
         _set_mandatory_tag(event)
 
     return [event['responseElements']['aRN'].split(':')[-1]]
 
 
 def _process_create_replication_group(event: dict, set_tag: bool = False) -> list:
 
-    if set_tag is True:
+    if set_tag:
         _set_mandatory_tag(event)
 
     return [event['responseElements']['aRN'].split(':')[-1]]

layer/python/cloudtrail_watcher/services/elasticloadbalancing.py

@@ -10,7 +10,7 @@ def _process_create_load_balancer(event: dict, set_tags: bool = False) -> list:
 
     is_clb = 'type' not in event['requestParameters']
 
-    if set_tags is True:
+    if set_tags:
         if is_clb is True:
             response = elb.describe_tags(LoadBalancerNames=[event['requestParameters']['loadBalancerName']])
         else:
@@ -20,7 +20,7 @@ def _process_create_load_balancer(event: dict, set_tags: bool = False) -> list:
 
         exists_mandatory_tags = check_contain_mandatory_tag_list(response['TagDescriptions'][0]['Tags'])
 
-        if exists_mandatory_tags is False:
+        if not exists_mandatory_tags:
             if is_clb is True:
                 elb.add_tags(
                     LoadBalancerNames=[event['requestParameters']['loadBalancerName']],

layer/python/cloudtrail_watcher/services/elasticmapreduce.py

@@ -10,7 +10,7 @@ def _process_run_job_flow(event: dict, set_tag: bool = False) -> list:
 
     job_flow_id = event['responseElements']['jobFlowId']
 
-    if set_tag is True:
+    if set_tag:
         if 'tags' not in event['requestParameters'] or \
                 check_contain_mandatory_tag_list(event['requestParameters']['tags']) is False:
             emr.add_tags(