feat: add concept of unowned globs to team configs (#117)

* feat: add concept of unonwed globs to team configs

* only remove the entries for the current team

* remove .idea/ from .gitignore

Author: mscrivo

lib/code_ownership/private/ownership_mappers/team_globs.rb

@@ -14,10 +14,9 @@ class TeamGlobs
         @@map_files_to_owners = {} # rubocop:disable Style/ClassVars
 
         sig do
-          params(files: T::Array[String])
-          .returns(T::Hash[String, ::CodeTeams::Team])
+          returns(T::Hash[String, ::CodeTeams::Team])
         end
-        def map_files_to_owners(files)
+        def map_files_to_owners
           return @@map_files_to_owners if @@map_files_to_owners&.keys && @@map_files_to_owners.keys.count.positive?
 
           @@map_files_to_owners = CodeTeams.all.each_with_object({}) do |team, map| # rubocop:disable Style/ClassVars
@@ -26,6 +25,13 @@ def map_files_to_owners(files)
                 map[filename] = team
               end
             end
+
+            # Remove anything that is unowned
+            TeamPlugins::Ownership.for(team).unowned_globs.each do |glob|
+              Dir.glob(glob).each do |filename|
+                map.delete(filename)
+              end
+            end
           end
         end
 
@@ -63,6 +69,12 @@ def find_overlapping_globs
                 T.must(mapped_files[filename]) << MappingContext.new(glob: glob, team: team)
               end
             end
+            # Remove anything that is unowned
+            TeamPlugins::Ownership.for(team).unowned_globs.each do |glob|
+              Dir.glob(glob).each do |filename|
+                mapped_files.reject! { |key, value| key == filename && value.any? { |context| context.team == team } }
+              end
+            end
           end
 
           overlaps = T.let([], T::Array[GlobOverlap])
@@ -81,10 +93,10 @@ def find_overlapping_globs
 
         sig do
           override.params(file: String)
-            .returns(T.nilable(::CodeTeams::Team))
+                  .returns(T.nilable(::CodeTeams::Team))
         end
         def map_file_to_owner(file)
-          map_files_to_owners([file])[file]
+          map_files_to_owners[file]
         end
 
         sig do
@@ -96,7 +108,7 @@ def update_cache(cache, files)
 
         sig do
           override.params(files: T::Array[String])
-            .returns(T::Hash[String, ::CodeTeams::Team])
+                  .returns(T::Hash[String, ::CodeTeams::Team])
         end
         def globs_to_owner(files)
           CodeTeams.all.each_with_object({}) do |team, map|

lib/code_ownership/private/team_plugins/ownership.rb

@@ -11,6 +11,11 @@ class Ownership < CodeTeams::Plugin
         def owned_globs
           @team.raw_hash['owned_globs'] || []
         end
+
+        sig { returns(T::Array[String]) }
+        def unowned_globs
+          @team.raw_hash['unowned_globs'] || []
+        end
       end
     end
   end

spec/lib/code_ownership/private/ownership_mappers/team_globs_spec.rb

@@ -9,16 +9,26 @@ module CodeOwnership
           owned_globs:
             - app/services/bar_stuff/**/**
             - frontend/javascripts/bar_stuff/**/**
+            - '**/team_thing/**/*'
+          unowned_globs:
+            - shared/**/team_thing/**/*
         CONTENTS
 
         write_file('app/services/bar_stuff/thing.rb')
         write_file('app/services/bar_stuff/[test]/thing.rb')
         write_file('frontend/javascripts/bar_stuff/thing.jsx')
+        write_file('app/services/team_thing/thing.rb')
+        write_file('shared/config/team_thing/something.rb')
       end
 
       it 'can find the owner of ruby files in owned_globs' do
         expect(CodeOwnership.for_file('app/services/bar_stuff/thing.rb').name).to eq 'Bar'
         expect(CodeOwnership.for_file('app/services/bar_stuff/[test]/thing.rb').name).to eq 'Bar'
+        expect(CodeOwnership.for_file('app/services/team_thing/thing.rb').name).to eq 'Bar'
+      end
+
+      it 'does not find the owner of ruby files in unowned_globs' do
+        expect(CodeOwnership.for_file('shared/config/team_thing/something.rb')).to be_nil
       end
 
       it 'can find the owner of javascript files in owned_globs' do
@@ -27,6 +37,24 @@ module CodeOwnership
     end
 
     describe 'CodeOwnership.validate!' do
+      context 'has unowned globs' do
+        before do
+          write_file('config/teams/bar.yml', <<~CONTENTS)
+            name: Bar
+            owned_globs:
+              - app/services/bar_stuff/**/**
+              - frontend/javascripts/bar_stuff/**/**
+              - '**/team_thing/**/*'
+            unowned_globs:
+              - shared/**/team_thing/**/*
+          CONTENTS
+        end
+
+        it 'considers the combination of owned_globs and unowned_globs' do
+          expect { CodeOwnership.validate! }.to_not raise_error
+        end
+      end
+
       context 'two teams own the same exact glob' do
         before do
           write_configuration