From 56d6b1e54d203f91922fe41ad9da3e96aa25da39 Mon Sep 17 00:00:00 2001 From: Hamza Tarar Date: Tue, 17 Nov 2026 23:59:04 +0500 Subject: [PATCH] Return nil, not false, when a line carries no literal get_literal_size ends in a && chain, so it returned false rather than nil when the line does not end with a literal prefix. read_line stores that in @literal_size before guard_response_too_large! runs, so a line that exceeded max_response_size produced a ResponseTooLargeError whose literal_size was false instead of nil. Nothing else changes: done? and min_response_remaining treat false and nil alike, and response_size_msg already treats false as falsy, so only the attribute value differs. --- lib/net/imap/response_reader.rb | 7 +++++-- test/net/imap/test_response_reader.rb | 20 ++++++++++++++++++++ 2 files changed, 25 insertions(+), 2 deletions(-) diff --git a/lib/net/imap/response_reader.rb b/lib/net/imap/response_reader.rb index c689ff9e5..006f939c1 100644 --- a/lib/net/imap/response_reader.rb +++ b/lib/net/imap/response_reader.rb @@ -48,8 +48,11 @@ def done? = line_done? && !literal_size def line_done? = buff.end_with?(CRLF) def get_literal_size(buff) - buff.end_with?("}\r\n") && buff.rindex(/\{(\d+)\}\r\n\z/n) && - coerce_number64($1) + # Returning nil rather than false keeps ResponseTooLargeError#literal_size + # nil when the line, not a literal, is what exceeded max_response_size. + return unless buff.end_with?("}\r\n") && buff.rindex(/\{(\d+)\}\r\n\z/n) + + coerce_number64($1) rescue DataFormatError raise DataFormatError, format("invalid response literal size (%s)", $1) end diff --git a/test/net/imap/test_response_reader.rb b/test/net/imap/test_response_reader.rb index 49e0b8b3a..53932d94f 100644 --- a/test/net/imap/test_response_reader.rb +++ b/test/net/imap/test_response_reader.rb @@ -76,6 +76,26 @@ def literal(str) = "{#{str.bytesize}}\r\n#{str}" end end + test "#read_response_buffer literal_size is only set by an oversized literal" do + client = FakeClient.new + client.config.max_response_size = 10 + + # The line is what exceeds the limit, so there is no literal size to report. + long_line = "+ 34567890\r\n" + error = assert_raise Net::IMAP::ResponseTooLargeError do + Net::IMAP::ResponseReader.new(client, StringIO.new(long_line, "rb")) + .read_response_buffer + end + assert_nil error.literal_size + + big_literal = "+ {200}\r\n" + error = assert_raise Net::IMAP::ResponseTooLargeError do + Net::IMAP::ResponseReader.new(client, StringIO.new(big_literal, "rb")) + .read_response_buffer + end + assert_equal 200, error.literal_size + end + test "#read_response_buffer max_response_size straddling CRLF" do barely_over = "+ 3456789\r\n" # CRLF straddles the boundary client = FakeClient.new