fix csv generation

Author: markburns

lib/problematic_variable_finder/formatters/cli_formatter.rb

@@ -11,14 +11,11 @@ def initialize(gem_name, problems)
       end 
 
       def call
-        csv = CSV.new(STDOUT)
-        csv << ['gem', 'location', 'type', 'value']
-
         problems.each do |path, (full_path, file_problems)|
           puts
 
           file_problems.each do |problem|
-            csv << display_problem(full_path, path, problem)
+            display_problem(full_path, path, problem)
           end
         end
       end

lib/problematic_variable_finder/formatters/csv.rb

@@ -1,12 +1,44 @@
-require 'problematic_variable_finder/formatters/display_cli_problem'
+require 'problematic_variable_finder/formatters/cli_formatter'
+require 'problematic_variable_finder/formatters/display_csv_problem'
+require 'csv'
 
 module ProblematicVariableFinder
   module Formatters
     class Csv < CliFormatter
+      def call
+        write_mode = File.exist?(csv_filename) ? "a" : "w"
+
+        CSV.open(csv_filename, "#{write_mode}b") do |csv|
+          csv << [
+            'github_link',
+            'gem_name',
+            'gem_version',
+            'location',
+            'type',
+            'code'
+          ]
+
+          problems.each do |gem_with_version, gem_problems|
+            puts
+
+            gem_problems.each do |problem|
+              csv << display_problem(problem)
+            end
+          end
+
+          csv
+        end
+      end
+
+
       private
 
-      def display_problem(full_path, path, problem)
-        DisplayCsvProblem.new(gem_name, full_path, path, problem).call
+      def csv_filename
+        "problematic_variables.csv"
+      end
+
+      def display_problem(problem)
+        DisplayCsvProblem.new(problem).call
       end
     end
   end

lib/problematic_variable_finder/formatters/display_csv_problem.rb

@@ -1,8 +1,20 @@
 module ProblematicVariableFinder
   module Formatters
     class DisplayCsvProblem < DisplayCliProblem
+      def initialize(problem)
+        @problem = problem
+      end
+
       def call
-        [gem_name, "#{path}:#{line_number}", problem[:type],  problem[:name].to_s]
+        [
+          problem.github_link,
+          problem.gem_name,
+          problem.gem_version,
+          problem.out_of_date,
+          "#{problem.path}:#{problem.line_number}",
+          problem.type,
+          problem.code
+        ]
       end
     end
   end

lib/problematic_variable_finder/gem_problems.rb

@@ -1,3 +1,5 @@
+require 'problematic_variable_finder/problem'
+
 module ProblematicVariableFinder
   class GemProblems
     include FsCaching
@@ -25,16 +27,32 @@ def determine_problems
           find_gem_problems(name, version)
         end
 
-        gem_is_out_of_date = outdated_gems.include?(name)
+        gem_problems = objectify(gem_problems)
 
-        problems[key] = [gem_problems, gem_is_out_of_date] if gem_problems.any?
+        problems[key] = gem_problems if gem_problems.any?
       end
 
       puts problems
 
       problems
     end
 
+    def objectify(gem_problems)
+      gem_problems.flat_map do |filename, file_problems|
+        file_problems.map do |problem|
+          Problem.new(
+            gem_name: name,
+            gem_version: version,
+            type: problem[:type],
+            filename: filename,
+            line_number: problem[:line_number],
+            code: problem[:name].to_s,
+            out_of_date: outdated_gems.include?(name)
+          )
+        end
+      end
+    end
+
     def exclude_because_of_only_list?(name)
       return false unless options[:gems]
 

lib/problematic_variable_finder/problem_finder.rb

@@ -1,4 +1,5 @@
 require 'problematic_variable_finder/main_finder'
+require 'problematic_variable_finder/problem'
 
 module ProblematicVariableFinder
   class ProblemFinder
@@ -7,15 +8,15 @@ class ProblemFinder
     def find_problems_in_directory(path, remove_paths=[])
       key = [path, remove_paths].inspect
 
-        files = Dir.glob("#{path}/**/*.rb")
+      files = Dir.glob("#{path}/**/*.rb")
 
-        files.reject! do |f|
-          filename = f
-          filename = remove_paths.each do |path|
-            filename = filename.gsub(path, '')
-          end
+      files.reject! do |f|
+        filename = f
+        filename = remove_paths.each do |path|
+          filename = filename.gsub(path, '')
+        end
 
-          %w(
+        %w(
             /spec/
             /.bundle/
             /.gems/
@@ -27,20 +28,31 @@ def find_problems_in_directory(path, remove_paths=[])
             /vendor/
             _spec.rb
             _test.rb
-          ).any? do |s|
-            filename.include?(s)
-          end
+        ).any? do |s|
+          filename.include?(s)
         end
+      end
 
-        directory_problems = {}
+      directory_problems = {}
 
-        files.each do |f|
-          puts f
-          full_path, path, problems = find_file_problems(f, remove_paths)
-          directory_problems[path]  = [full_path, problems] if problems.any?
+      files.each do |f|
+        puts f
+        full_path, path, problems = find_file_problems(f, remove_paths)
+        problems.map! do |problem|
+          Problem.new(
+            gem_name: name,
+            gem_version: version,
+            type: problem[:type],
+            filename: filename,
+            line_number: problem[:line_number],
+            code: problem[:name].to_s,
+            out_of_date: outdated_gems.include?(name)
+          )
         end
+        directory_problems[path]  = [full_path, problems] if problems.any?
+      end
 
-        directory_problems
+      directory_problems
     end
 
     def find_file_problems(f, remove_paths)

lib/problematic_variable_finder/runner.rb

@@ -30,7 +30,7 @@ def call
 
     def display_gem_problems
       each_gem_problem do |gem_name, problems, out_of_date|
-        if options[:verbose] 
+        if options[:verbose]
           display_problems(gem_name, problems)
         else
           puts '-----------------'