Skip to content

Commit aa883b0

Browse files
committed
fix ignoring option
1 parent 2e154e3 commit aa883b0

1 file changed

Lines changed: 16 additions & 5 deletions

File tree

lib/problematic_variable_finder/gem_problems.rb

Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,8 @@ def determine_problems
1717
problems = {}
1818

1919
gems.each do |name, version|
20-
next if Array(options[:ignore]).include?(name)
21-
22-
if Array(options[:gems]).any?
23-
next unless options[:gems].include?(name)
24-
end
20+
next if ignore_gem?(name)
21+
next if exclude_because_of_only_list?(name)
2522

2623
key = "#{name}-#{version}"
2724

@@ -39,6 +36,20 @@ def determine_problems
3936
problems
4037
end
4138

39+
def exclude_because_of_only_list?(name)
40+
return false unless options[:gems]
41+
42+
!in_only_gem_list?(name)
43+
end
44+
45+
def in_only_gem_list?(name)
46+
Array(options[:gems]).include?(name)
47+
end
48+
49+
def ignore_gem?(name)
50+
options[:ignore] && Array(options[:ignore]).include?(name)
51+
end
52+
4253
def outdated_gems
4354
@outdated_gems ||= outdated.map{|o| o.gsub(/\s+\*\s+/, '').split(" ").first }
4455
end

0 commit comments

Comments
 (0)