Cleanup, beta 3 preparation

Author: andrewvk

Build/Props/CodeJam.Default.props

@@ -10,7 +10,7 @@
 		<AssemblyOriginatorKeyFile>..\Build\CodeJam.snk</AssemblyOriginatorKeyFile>
 
 		<Version>3.0.1.0</Version>
-		<PackageVersion>3.0.1-beta2</PackageVersion>
+		<PackageVersion>3.0.1-beta3</PackageVersion>
 		<PackageOutputPath>..\_Results</PackageOutputPath>
 
 		<Company>RSDN</Company>

CodeJam.Main/Arithmetic/OperatorsFactory.cs

@@ -420,6 +420,7 @@ public static Func<T, T, bool> ComparisonOperator<T>(ExpressionType comparisonTy
 		[NotNull]
 		private static Func<T, T, bool> GetComparerComparison<T>(ExpressionType comparisonType)
 		{
+			// ReSharper disable once SwitchStatementMissingSomeEnumCasesNoDefault
 			switch (comparisonType)
 			{
 				case ExpressionType.Equal:

CodeJam.Main/Assertions/Code.cs

@@ -16,6 +16,7 @@
 #endif
 
 using static CodeJam.Targeting.MethodImplOptionsEx;
+// ReSharper disable BuiltInTypeReferenceStyleForMemberAccess
 
 namespace CodeJam
 {

CodeJam.Main/Collections/ComparerBuilder.cs

@@ -3,7 +3,6 @@
 using System.Collections.Generic;
 using System.Linq;
 using System.Linq.Expressions;
-using System.Reflection;
 
 using JetBrains.Annotations;
 

CodeJam.Main/EnumHelper.Holder.cs

@@ -101,7 +101,7 @@ private static TEnum[] GetNonDefaultUniqueFlagsCore()
 				static int GetNumberOfSetBits(TEnum value)
 				{
 					var i = Convert.ToUInt64(value);
-					i = i - ((i >> 1) & 0x5555555555555555UL);
+					i -= (i >> 1) & 0x5555555555555555UL;
 					i = (i & 0x3333333333333333UL) + ((i >> 2) & 0x3333333333333333UL);
 					return (int)(unchecked(((i + (i >> 4)) & 0xF0F0F0F0F0F0F0FUL) * 0x101010101010101UL) >> 56);
 				}

CodeJam.Main/EnumHelper.cs

@@ -235,7 +235,7 @@ public static bool IsDefined<TEnum>([NotNull] string value)
 		public static bool AreFlagsDefined<TEnum>(TEnum flags)
 			where TEnum : struct, Enum =>
 				IsDefined(flags)
-				|| (MetaHolder<TEnum>.IsFlagsEnum && OpHolder<TEnum>.IsFlagSetCallback(MetaHolder<TEnum>.ValuesMask, flags));
+				|| MetaHolder<TEnum>.IsFlagsEnum && OpHolder<TEnum>.IsFlagSetCallback(MetaHolder<TEnum>.ValuesMask, flags);
 
 		/// <summary>Determines whether all bits of the flags combination are defined.</summary>
 		/// <typeparam name="TEnum">The type of the enum.</typeparam>

CodeJam.Main/Expressions/ExpressionExtensions.cs

@@ -45,6 +45,7 @@ private static void VisitInternal([CanBeNull] this Expression expr, [NotNull, In
 			if (expr == null)
 				return;
 
+			// ReSharper disable once SwitchStatementMissingSomeEnumCasesNoDefault
 			switch (expr.NodeType)
 			{
 				case ExpressionType.Add:
@@ -323,9 +324,6 @@ void Action(MemberBinding b)
 						VisitInternal(expr.Reduce(), func);
 					break;
 				}
-
-				default:
-					break;
 			}
 
 			func(expr);
@@ -362,6 +360,7 @@ private static void VisitInternal([CanBeNull] this Expression expr, [NotNull, In
 			if (expr == null || !func(expr))
 				return;
 
+			// ReSharper disable once SwitchStatementMissingSomeEnumCasesNoDefault
 			switch (expr.NodeType)
 			{
 				case ExpressionType.Add:
@@ -708,6 +707,7 @@ private static Expression FindInternal(this Expression expr, Func<Expression, bo
 			if (expr == null || func(expr))
 				return expr;
 
+			// ReSharper disable once SwitchStatementMissingSomeEnumCasesNoDefault
 			switch (expr.NodeType)
 			{
 				case ExpressionType.Add:

CodeJam.Main/Readme.txt

@@ -5,7 +5,15 @@ What's new in 3.0.1-beta3
 -------------------------
 * IsAssignableTo() reflection helper.
 * Deconstruct methods for arrays, lists and enumerables (to support positional pattern).
-* Code cleanup
+* !Breaking change!: EnumHelper.GetFlagsMask() replaced with EnumHelper.GetValuesMask() method.
+* Algorithms.MinMax(). Math.Min/Max() for any comparable type.
+* EnumHelper.GetDefinedFlags(value).
+* EnumHelper.ToFlags(value) extension method.
+* Code cleanup.
+* WaitForCancellationAsync() extension method.
+* TimeoutHelper class.
+* WithTimeout() methods.
+* Refactoring and code cleanup
 
 What's new in 3.0.1-beta2
 -------------------------

CodeJam.Main/Strings/CharExtensions.cs

@@ -4,6 +4,7 @@
 
 #if TARGETS_NET || NETSTANDARD20_OR_GREATER || NETCOREAPP20_OR_GREATER
 using CharEx = System.Char;
+// ReSharper disable BuiltInTypeReferenceStyleForMemberAccess
 #else
 using CharEx = System.CharEx;
 #endif

CodeJam.Main/Targeting/TypeExtensions.cs

@@ -261,7 +261,7 @@ public static Attribute[] GetCustomAttributes([NotNull] this Type type, Type att
 #endif
 
 		[MethodImpl(AggressiveInlining)]
-		public static object GetCustomAttributeWithInterfaceSupport(
+		private static object GetCustomAttributeWithInterfaceSupport(
 			[NotNull] this Type type, Type attributeType, bool inherit)
 		{
 #if TARGETS_NET || NETSTANDARD20_OR_GREATER || NETCOREAPP20_OR_GREATER
@@ -293,7 +293,7 @@ public static T GetCustomAttributeWithInterfaceSupport<T>([NotNull] this Type ty
 				(T)GetCustomAttributeWithInterfaceSupport(type, typeof(T), inherit);
 
 		[MethodImpl(AggressiveInlining)]
-		public static IEnumerable<Attribute> GetCustomAttributesWithInterfaceSupport(
+		private static IEnumerable<Attribute> GetCustomAttributesWithInterfaceSupport(
 			[NotNull] this Type type, Type attributeType, bool inherit)
 		{
 #if TARGETS_NET || NETSTANDARD20_OR_GREATER || NETCOREAPP20_OR_GREATER