Move logic with Composer to a standalone class with interface

Author: msmakouz

src/Composer/Package.php

@@ -0,0 +1,32 @@
+<?php
+
+declare(strict_types=1);
+
+namespace RoadRunner\VersionChecker\Composer;
+
+use Composer\InstalledVersions;
+
+final class Package implements PackageInterface
+{
+    /**
+     * @param non-empty-string $packageName
+     * @return non-empty-string[]
+     */
+    public function getRequiredVersions(string $packageName): array
+    {
+        $versions = [];
+        foreach (InstalledVersions::getInstalledPackages() as $package) {
+            $path = InstalledVersions::getInstallPath($package);
+            if ($path !== null && \file_exists($path . '/composer.json')) {
+                /** @var array{require?: array<non-empty-string, non-empty-string>} $composerJson */
+                $composerJson = \json_decode(\file_get_contents($path . '/composer.json'), true);
+
+                if (isset($composerJson['require'][$packageName])) {
+                    $versions[] = $composerJson['require'][$packageName];
+                }
+            }
+        }
+
+        return $versions;
+    }
+}

src/Composer/PackageInterface.php

@@ -0,0 +1,14 @@
+<?php
+
+declare(strict_types=1);
+
+namespace RoadRunner\VersionChecker\Composer;
+
+interface PackageInterface
+{
+    /**
+     * @param non-empty-string $packageName
+     * @return non-empty-string[]
+     */
+    public function getRequiredVersions(string $packageName): array;
+}

src/Version/Required.php

@@ -4,14 +4,20 @@
 
 namespace RoadRunner\VersionChecker\Version;
 
-use Composer\InstalledVersions;
 use Composer\Semver\Comparator as SemverComparator;
 use Composer\Semver\VersionParser;
+use RoadRunner\VersionChecker\Composer\Package;
+use RoadRunner\VersionChecker\Composer\PackageInterface;
 
 final class Required implements RequiredInterface
 {
     private const ROADRUNNER_PACKAGE = 'spiral/roadrunner';
 
+    public function __construct(
+        private readonly PackageInterface $package = new Package()
+    ) {
+    }
+
     /**
      * @return non-empty-string|null
      */
@@ -20,23 +26,10 @@ public function getRequiredVersion(): ?string
         $parser = new VersionParser();
 
         $version = null;
-        foreach (InstalledVersions::getInstalledPackages() as $package) {
-            $path = InstalledVersions::getInstallPath($package);
-            if ($path !== null && \file_exists($path . '/composer.json')) {
-                /** @var array $composerJson */
-                $composerJson = \json_decode(\file_get_contents($path . '/composer.json'), true);
-
-                if (isset($composerJson['require']) && \is_array($composerJson['require'])) {
-                    /** @var non-empty-string $packageVersion */
-                    foreach ($composerJson['require'] as $package => $packageVersion) {
-                        if ($package === self::ROADRUNNER_PACKAGE) {
-                            /** @var non-empty-string $packageVersion */
-                            $packageVersion = $parser->normalize($packageVersion);
-                            $version = $this->getMinimumVersion($packageVersion, $version);
-                        }
-                    }
-                }
-            }
+        foreach ($this->package->getRequiredVersions(self::ROADRUNNER_PACKAGE) as $packageVersion) {
+            /** @var non-empty-string $packageVersion */
+            $packageVersion = $parser->normalize($packageVersion);
+            $version = $this->getMinimumVersion($packageVersion, $version);
         }
 
         return $version;