Fix getRequiredVersion (#2)

Author: msmakouz

src/Version/Required.php

@@ -34,7 +34,7 @@ public function getRequiredVersion(): ?string
         }
 
         foreach ($this->package->getRequiredVersions(self::ROADRUNNER_PACKAGE) as $packageVersion) {
-            self::$cachedVersion = $this->getMinimumVersion($packageVersion, self::$cachedVersion);
+            self::$cachedVersion = $this->getMaximumVersion($packageVersion, self::$cachedVersion);
         }
 
         return self::$cachedVersion;
@@ -45,12 +45,12 @@ public function getRequiredVersion(): ?string
      * @param non-empty-string|null $previous
      * @return non-empty-string
      */
-    private function getMinimumVersion(string $version, ?string $previous = null): string
+    private function getMaximumVersion(string $version, ?string $previous = null): string
     {
         if ($previous === null) {
             return $version;
         }
 
-        return SemverComparator::lessThan($version, $previous) ? $version : $previous;
+        return SemverComparator::greaterThan($version, $previous) ? $version : $previous;
     }
 }

tests/src/Unit/Version/RequiredTest.php

@@ -21,10 +21,10 @@ protected function tearDown(): void
     /**
      * @dataProvider versionsDataProvider
      */
-    public function testGetMinimumVersion(string $version, ?string $previous, string $expected): void
+    public function testGetMaximumVersion(string $version, ?string $previous, string $expected): void
     {
         $required = new Required();
-        $ref = new \ReflectionMethod($required, 'getMinimumVersion');
+        $ref = new \ReflectionMethod($required, 'getMaximumVersion');
         $ref->setAccessible(true);
 
         $this->assertSame($expected, $ref->invoke($required, $version, $previous));
@@ -41,7 +41,7 @@ public function testGetRequiredVersion(): void
 
         $required = new Required($package);
 
-        $this->assertSame('1.0', $required->getRequiredVersion());
+        $this->assertSame('2.0.0.0-dev', $required->getRequiredVersion());
     }
 
     public function testGetCachedVersion(): void
@@ -66,15 +66,15 @@ public static function versionsDataProvider(): \Traversable
         yield ['1.0.0', null, '1.0.0'];
 
         // Test case with $version < $previous
-        yield ['1.0.0', '2.0.0', '1.0.0'];
-        yield ['1.0.0-alpha', '1.0.0', '1.0.0-alpha'];
+        yield ['1.0.0', '2.0.0', '2.0.0'];
+        yield ['1.0.0-alpha', '1.0.0', '1.0.0'];
 
         // Test case with $version >= $previous
-        yield ['2.0.0', '1.0.0', '1.0.0'];
-        yield ['1.0.0', '1.0.0-alpha', '1.0.0-alpha'];
+        yield ['2.0.0', '1.0.0', '2.0.0'];
+        yield ['1.0.0', '1.0.0-alpha', '1.0.0'];
         yield ['1.0.0', '1.0.0', '1.0.0'];
 
-        yield ['1.0.0.0', '1.1.0', '1.0.0.0'];
-        yield ['1.0.0.0-dev', '1.0.0.0', '1.0.0.0-dev'];
+        yield ['1.0.0.0', '1.1.0', '1.1.0'];
+        yield ['1.0.0.0-dev', '1.0.0.0', '1.0.0.0'];
     }
 }