Bump github.com/riverqueue/river/rivershared from 0.24.0 to 0.25.0 in the go-dependencies group across 1 directory (#24)

Updates `github.com/riverqueue/river/rivershared` from 0.24.0 to 0.25.0

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Blake Gentry <blakesgentry@gmail.com>

Author: dependabot[bot]

.github/workflows/ci.yaml

@@ -29,7 +29,7 @@ jobs:
   golangci-lint:
     runs-on: ubuntu-latest
     env:
-      GOLANGCI_LINT_VERSION: v2.0.0
+      GOLANGCI_LINT_VERSION: v2.4.0
 
     steps:
       - name: Checkout

.golangci.yaml

@@ -25,6 +25,7 @@ linters:
     - ireturn # bans returning interfaces; questionable as is, but also buggy as hell; very, very annoying
     - lll # restricts maximum line length; annoying
     - nlreturn # requires a blank line before returns; annoying
+    - noinlineerr # disallows `if err := ...`; because why miss an opportunity to leak variables out of scope?
     - wsl # a bunch of style/whitespace stuff; annoying
 
   settings:

apiendpoint/api_endpoint.go

@@ -85,6 +85,7 @@ func (m *EndpointMeta) validate() {
 	if m.Pattern == "" {
 		panic("Endpoint.Path is required")
 	}
+
 	if m.StatusCode == 0 {
 		panic("Endpoint.StatusCode is required")
 	}
@@ -142,13 +143,15 @@ func executeAPIEndpoint[TReq any, TResp any](w http.ResponseWriter, r *http.Requ
 
 	err := func() error {
 		var req TReq
+
 		if r.Method != http.MethodGet {
 			reqData, err := io.ReadAll(r.Body)
 			if err != nil {
 				var maxBytesErr *http.MaxBytesError
 				if errors.As(err, &maxBytesErr) {
 					return apierror.NewRequestEntityTooLarge("Request entity too large.")
 				}
+
 				return fmt.Errorf("error reading request body: %w", err)
 			}
 
@@ -213,12 +216,14 @@ func executeAPIEndpoint[TReq any, TResp any](w http.ResponseWriter, r *http.Requ
 			logger.InfoContext(ctx, "API error response", logAttrs...)
 
 			apiErr.Write(ctx, logger, w)
+
 			return
 		}
 
 		if errors.Is(err, context.DeadlineExceeded) {
 			logger.ErrorContext(ctx, "request timeout", slog.String("error", err.Error()))
 			apierror.NewServiceUnavailable("Request timed out. Retrying the request might work.").Write(ctx, logger, w)
+
 			return
 		}
 

apiendpoint/api_endpoint_test.go

@@ -245,15 +245,18 @@ func mustMarshalJSON(t *testing.T, v any) []byte {
 
 	data, err := json.Marshal(v)
 	require.NoError(t, err)
+
 	return data
 }
 
 func mustUnmarshalJSON[T any](t *testing.T, data []byte) *T {
 	t.Helper()
 
 	var val T
+
 	err := json.Unmarshal(data, &val)
 	require.NoError(t, err)
+
 	return &val
 }
 
@@ -315,6 +318,7 @@ func (a *getEndpoint) Execute(_ context.Context, req *getRequest) (*getResponse,
 
 type postEndpoint struct {
 	Endpoint[postRequest, postResponse]
+
 	MaxBodyBytes int64
 }
 
@@ -341,6 +345,7 @@ func (req *postRequest) ExtractRaw(r *http.Request) error {
 	}
 
 	req.ID = r.PathValue("id")
+
 	return nil
 }
 

apierror/api_error_test.go

@@ -70,5 +70,6 @@ func mustMarshalJSON(t *testing.T, v any) []byte {
 
 	data, err := json.Marshal(v)
 	require.NoError(t, err)
+
 	return data
 }

apimiddleware/api_middleware.go

@@ -56,13 +56,15 @@ func NewMiddlewareStack(middlewares ...middlewareInterface) *MiddlewareStack {
 	for _, mw := range middlewares {
 		stack.Use(mw)
 	}
+
 	return stack
 }
 
 func (s *MiddlewareStack) Mount(handler http.Handler) http.Handler {
 	for i := len(s.middlewares) - 1; i >= 0; i-- {
 		handler = s.middlewares[i].Middleware(handler)
 	}
+
 	return handler
 }
 

apimiddleware/api_middleware_test.go

@@ -34,6 +34,7 @@ func (m *contextTrailMiddleware) Middleware(next http.Handler) http.Handler {
 		if existingTrail, ok := ctx.Value(contextTrailContextKey{}).([]string); ok {
 			contextTrail = existingTrail
 		}
+
 		contextTrail = append(contextTrail, m.segment)
 
 		next.ServeHTTP(w, r.WithContext(context.WithValue(ctx, contextTrailContextKey{}, contextTrail)))

apitest/apitest_test.go

@@ -19,6 +19,7 @@ func TestInvokeHandler(t *testing.T) {
 	type testRequest struct {
 		RequiredReqField string `json:"req_field" validate:"required"`
 	}
+
 	type testResponse struct {
 		RequiredRespField string `json:"resp_field" validate:"required"`
 	}

apitype/explicit_nullable.go

@@ -42,5 +42,6 @@ func ExtractExplicitNullableValueForValidation[T any](field reflect.Value) inter
 	if !ok || !ps.Set || ps.Value == nil {
 		return nil
 	}
+
 	return ps.Value
 }

apitype/explicit_nullable_test.go

@@ -56,6 +56,7 @@ func TestExplicitNullable_Validation(t *testing.T) {
 			t.Parallel()
 
 			var payload testPayload
+
 			err := json.Unmarshal([]byte(tt.json), &payload)
 			require.NoError(t, err)
 
@@ -104,6 +105,7 @@ func TestExtractExplicitNullableValueForValidation(t *testing.T) {
 			t.Parallel()
 
 			val := reflect.ValueOf(tt.input)
+
 			got := ExtractExplicitNullableValueForValidation[string](val)
 			if tt.wantVal == nil {
 				require.Nil(t, got)
@@ -159,6 +161,7 @@ func TestExplicitNullable_UnmarshalJSON(t *testing.T) {
 			t.Parallel()
 
 			var got testPayload
+
 			err := json.Unmarshal([]byte(tt.json), &got)
 
 			if tt.wantErr {