Skip to content

Commit 1a3d8ed

Browse files
authored
vulkan: use graphics queue on AMD (ggml-org#20551)
* vulkan: use graphics queue on AMD for slightly better performance * disable async transfer queue on AMD
1 parent 6b10a82 commit 1a3d8ed

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

ggml/src/ggml-vulkan/ggml-vulkan.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4981,8 +4981,10 @@ static vk_device ggml_vk_get_device(size_t idx) {
49814981
std::vector<vk::QueueFamilyProperties> queue_family_props = device->physical_device.getQueueFamilyProperties();
49824982

49834983
// Try to find a non-graphics compute queue and transfer-focused queues
4984-
const uint32_t compute_queue_family_index = ggml_vk_find_queue_family_index(queue_family_props, vk::QueueFlagBits::eCompute, vk::QueueFlagBits::eGraphics, -1, 1);
4985-
const uint32_t transfer_queue_family_index = ggml_vk_find_queue_family_index(queue_family_props, vk::QueueFlagBits::eTransfer, vk::QueueFlagBits::eCompute | vk::QueueFlagBits::eGraphics, compute_queue_family_index, 1);
4984+
// On AMD, the graphics queue seems to be faster, so don't avoid it
4985+
const vk::QueueFlagBits graphics_flag = device->vendor_id == VK_VENDOR_ID_AMD ? (vk::QueueFlagBits)0 : vk::QueueFlagBits::eGraphics;
4986+
const uint32_t compute_queue_family_index = ggml_vk_find_queue_family_index(queue_family_props, vk::QueueFlagBits::eCompute, graphics_flag, -1, 1);
4987+
const uint32_t transfer_queue_family_index = ggml_vk_find_queue_family_index(queue_family_props, vk::QueueFlagBits::eTransfer, vk::QueueFlagBits::eCompute | graphics_flag, compute_queue_family_index, 1);
49864988

49874989
const float priorities[] = { 1.0f, 1.0f };
49884990
device->single_queue = compute_queue_family_index == transfer_queue_family_index && queue_family_props[compute_queue_family_index].queueCount == 1;
@@ -5441,13 +5443,11 @@ static vk_device ggml_vk_get_device(size_t idx) {
54415443

54425444
ggml_vk_load_shaders(device);
54435445

5444-
const bool prefers_transfer_queue = device->vendor_id == VK_VENDOR_ID_AMD && device->architecture != AMD_GCN;
5445-
54465446
if (!device->single_queue) {
54475447
const uint32_t transfer_queue_index = compute_queue_family_index == transfer_queue_family_index ? 1 : 0;
54485448
ggml_vk_create_queue(device, device->transfer_queue, transfer_queue_family_index, transfer_queue_index, { vk::PipelineStageFlagBits::eTransfer }, true);
54495449

5450-
device->async_use_transfer_queue = prefers_transfer_queue || (getenv("GGML_VK_ASYNC_USE_TRANSFER_QUEUE") != nullptr);
5450+
device->async_use_transfer_queue = (getenv("GGML_VK_ASYNC_USE_TRANSFER_QUEUE") != nullptr);
54515451
} else {
54525452
// TODO: Use pointer or reference to avoid copy
54535453
device->transfer_queue.copyFrom(device->compute_queue);

0 commit comments

Comments
 (0)