Skip to content

Commit a27aeb0

Browse files
jiridanekpematous
authored andcommitted
FIX: catch all exceptions from connector threads
Previously, exceptions other than `coreclient.ClientException` were only logged to stderr, but the error result was not updated, so the client ended with return code 0 even if there were errors.
1 parent 2666999 commit a27aeb0

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

cli_proton_python/connector.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,7 @@ def run_connectors(opts, results, errors, stats=None):
205205
super(proton.reactor.Container, container).global_handler.add(
206206
coreclient.ErrorsHandler(opts.conn_reconnect))
207207
container.run()
208-
except coreclient.ClientException as exc:
208+
except (coreclient.ClientException, Exception) as exc:
209209
simple_connector.result['connection']['error'] = 1
210210
errors.append(str(exc))
211211
finally:

0 commit comments

Comments
 (0)