wrong ppx

[bobzhang]

let bla foo bar baz = foo##(bar##baz)

This should fail to compile instead of weird output

[bobzhang]

Here is an explanation whyfoo##(bar##baz) works
bucklescript allows chaining as below:

foo##(method1 a b )##(method2 a b)

which is the same as

let result = foo##method1 a b in 
result##method2 a b 

foo##(bar##baz) is parsed as

foo##( (##) bar baz)

relevant reasonml/reason#941

[bobzhang]

proposal fix: do a sanity check, don't allow method name to have #?
cc @chenglou

[bobzhang]

actually the right fix is apply ast rewrite recursively first in the inner ast, then we get a more sensible error message

[bobzhang]

current rewrite rules
Pexp_apply(fn,args) pattern math fn and args before it is rewritten, this cause some confusion. a more polished fix is always rewrote subexpression before pattern match.
This is not a critical bug, let's leave it for next release

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.