From 3d8a45ec46a4701d05355cfa30192b62022bd03f Mon Sep 17 00:00:00 2001 From: "roboco-app[bot]" <302741806+roboco-app[bot]@users.noreply.github.com> Date: Tue, 3 Nov 2026 14:52:40 +0000 Subject: [PATCH] [d03a0c3d] docs(frontend): link approved-view doc in index, delete stray CI note (#1409) Co-authored-by: Frontend Developer 1 --- docs/frontend/README.md | 1 + .../pr-1370-python-gate-base-regression.md | 34 ------------------- 2 files changed, 1 insertion(+), 34 deletions(-) delete mode 100644 docs/frontend/pr-1370-python-gate-base-regression.md diff --git a/docs/frontend/README.md b/docs/frontend/README.md index b8226cbcc..88cbcbe19 100644 --- a/docs/frontend/README.md +++ b/docs/frontend/README.md @@ -13,6 +13,7 @@ Documentation for the Frontend Cell team. - [Page-scoped refresh provider](./components/page-refresh-provider.md) — `PageRefreshProvider` callback registry that lets the navbar refresh button re-fetch only the current page. - [Project selector](./components/project-selector.md) — `ProjectSelector` dropdown for picking a project, with optional filtering by team and video-engine enablement. - [Portfolio cards](./components/portfolio-cards.md) — `PortfolioCards` CEO-only per-project metrics cards (five metrics, endpoint-order sort, `/tasks?project=` drill-down) with the `CeoGate`/`panel-role` gating seam and the known slug-vs-`project_id` drill-down follow-up. + - [Playbook approved view](./components/playbook-approved-view.md) — the Approved tab of the dashboard Playbook Review card, listing approved playbooks with an Archive action that also removes them from the KB. - `/hooks/` - Hook documentation - `/qa/` - QA-related docs diff --git a/docs/frontend/pr-1370-python-gate-base-regression.md b/docs/frontend/pr-1370-python-gate-base-regression.md deleted file mode 100644 index 2e8ba8c7a..000000000 --- a/docs/frontend/pr-1370-python-gate-base-regression.md +++ /dev/null @@ -1,34 +0,0 @@ -# PR 1370 red Python quality gate: base regression finding - -Task `04d83ee5` (PR #1378, branch `feature/frontend/4559be66--241582c0--04d83ee5`). - -## Outcome - -The red "Python quality gate" on PR #1370 is not caused by the frontend feature. `make quality` run in the task worktree after `sync_branch` (which reported the branch already current) fails at the **pytest** step: 9 failed, 17031 passed. None of the failing tests touch `panel/src` or `docs/frontend`; they come from base/slave-branch drift and were deliberately left unedited. - -## Failing tests (base regression, for the PM to escalate) - -| File | Tests | -|---|---| -| `tests/unit/llm/providers/test_hummin_cli_config.py` | `test_main_renders_settings_and_env_file` | -| `tests/unit/runtime/test_stale_review_claim_reaper.py` | `test_dead_claimant_released`, `test_dispatch_pause_defers_release`, `test_sweep_wires_the_review_pass` | -| `tests/unit/test_ci_workflow_paths.py` | `test_every_markdown_file_the_prose_gate_checks_fires_ci`, `test_every_python_file_fires_ci`, `test_every_workflow_path_filter_matches_a_tracked_file` | -| `tests/unit/test_required_checks.py` | `test_every_file_codeql_analyzes_is_under_its_workflows_paths[code-ql.yml / codeql-js-ts.yml]` | - -## What this task changed - -Only prettier formatting, which had turned the `panel-gate` prettier step red: - -- `panel/src/components/dashboard/playbook-approved-list.tsx`: the empty-state paragraph is wrapped across lines. -- `panel/src/components/dashboard/__tests__/playbook-approved-list.test.tsx`: the `renderQueue` default-argument `QueryClient` is reformatted. - -No behavior changed. No Python or config files were edited. - -## Verification notes - -- `make panel-gate`: prettier now passes. Vitest passes except one `ai-routing-card` picker test that timed out under load; it passes in isolation (60/60). -- `make quality` takes roughly 10 minutes. - -## Follow-up - -Until the nine Python tests above are fixed on the base, the Python quality gate will stay red on this branch and `pr_pass` will keep refusing. The PM should raise this as a base regression.