Yum or subscription-manager may fail on an unstable network

Adding retry is a workaround for mitigating random networking issues.

Author: jprovaznik

fragments/bastion-boot.sh

@@ -153,11 +153,11 @@ then
 else
     verify_os_collect_config_is_installed
 
-    yum -y install git httpd-tools ||
+    retry yum -y install git httpd-tools ||
         notify_failure "could not install httpd-tools"
 
     # ensure openssl is installed on CentOS
-    yum -y install pyOpenSSL ||
+    retry yum -y install pyOpenSSL ||
         notify_failure "could not install pyOpenSSL"
 
     extra_opts=""
@@ -175,7 +175,7 @@ else
             $OPENSHIFT_ANSIBLE_GIT_URL \
             $OPENSHIFT_ANSIBLE_GIT_REV
     else
-        yum -y install openshift-ansible-roles openshift-ansible-playbooks \
+        retry yum -y install openshift-ansible-roles openshift-ansible-playbooks \
             || notify_failure "could not install openshift-ansible"
     fi
 fi

fragments/common_openshift_functions.sh

@@ -17,7 +17,7 @@ function sudo_set_secure_path() {
 function docker_install_and_enable() {
     if ! rpm -q docker
     then
-        yum -y install docker || notify_failure "could not install docker"
+        retry yum -y install docker || notify_failure "could not install docker"
     fi
     systemctl enable docker
 }

fragments/host-update.sh

@@ -28,6 +28,6 @@ then
     atomic host upgrade || notify_failure "failed to run 'atomic host upgrade'"
 else
     # Update using traditional RPMs
-    yum install -y deltarpm || notify_failure "could not install deltarpm"
-    [ "$SYSTEM_UPDATE" = "True" ] && (yum -y update || notify_failure "could not update RPMs")
+    retry yum install -y deltarpm || notify_failure "could not install deltarpm"
+    [ "$SYSTEM_UPDATE" = "True" ] && (retry yum -y update || notify_failure "could not update RPMs")
 fi

fragments/rhn-register.sh

@@ -41,7 +41,7 @@ function install_sat6_ca_certs() {
     local SAT6_KEY_RPM_URL="https://${1}/pub/katello-ca-consumer-latest.noarch.rpm"
 
     if ! rpm -q --quiet $SAT6_KEY_RPM ; then
-        yum -y install $SAT6_KEY_RPM_URL
+        retry yum -y install $SAT6_KEY_RPM_URL
     fi
 }
 
@@ -67,18 +67,18 @@ fi
 
 # Attach to an entitlement pool
 if [ -n "$POOL_ID" ]; then
-    subscription-manager attach --pool $POOL_ID
+    retry subscription-manager attach --pool $POOL_ID
 else
-    subscription-manager attach --auto
+    retry subscription-manager attach --auto
 fi
 
 if [ -n "$EXTRA_POOL_IDS" ]; then
-    subscription-manager attach --pool $EXTRA_POOL_IDS
+    retry subscription-manager attach --pool $EXTRA_POOL_IDS
 fi
 
 # Select the YUM repositories to use
-subscription-manager repos --disable="*"
-subscription-manager repos \
+retry subscription-manager repos --disable="*"
+retry subscription-manager repos \
                      --enable="rhel-7-server-rpms" \
                      --enable="rhel-7-server-extras-rpms" \
                      --enable="rhel-7-server-optional-rpms" \