Skip to content

Commit 7233ab2

Browse files
authored
Merge pull request #316 from markllama/ansible-version
allow a caller to specify the ansible version for OCP install
2 parents f431ff8 + 2feba13 commit 7233ab2

3 files changed

Lines changed: 26 additions & 2 deletions

File tree

bastion.yaml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,21 @@ parameters:
1414
description: >
1515
The version of OpenShift Container Platform to deploy
1616
17-
# What version of OpenStack Platform to install
17+
# What version of OpenStack Platform to install
1818
# This value is used to select the RPM repo for the OSP release to install
1919
osp_version:
2020
type: string
2121
default: "10"
2222
description: >
2323
The version of OpenStack Platform to use to collect data
2424
25+
# Allow the caller to specify the version of ansible
26+
ansible_version:
27+
type: string
28+
description: >
29+
Set the RPM version of Ansible that will run on the bastion
30+
If unset, use current version
31+
2532
key_name:
2633
description: >
2734
A pre-submitted SSH key to access the VM hosts
@@ -246,6 +253,7 @@ resources:
246253
$OPENSHIFT_ANSIBLE_GIT_URL: {get_param: openshift_ansible_git_url}
247254
$OPENSHIFT_ANSIBLE_GIT_REV: {get_param: openshift_ansible_git_rev}
248255
$DOCKER_VOLUME_ID: {get_resource: docker_volume}
256+
$ANSIBLE_VERSION: {get_param: ansible_version}
249257
template: {get_file: fragments/bastion-boot.sh}
250258

251259
# Compose the FQDN for cloud-init

fragments/bastion-boot.sh

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@
1111
# openshift ansible playbooks and configs
1212
# OPENSHIFT_ANSIBLE_GIT_REV - the release/revision of the playbooks to use
1313
#
14+
# ANSIBLE_VERSION - the version of of ansible to use for OCP installation
15+
#
1416

1517
# Exit on first command failure or undefined var reference
1618
set -eu
@@ -167,7 +169,12 @@ else
167169
install_epel_repos_disabled $EPEL_RELEASE_VERSION
168170
extra_opts="--enablerepo=epel"
169171
fi
170-
retry yum -y $extra_opts install ansible ||
172+
if [ -z "$ANSIBLE_VERSION" ] ; then
173+
ANSIBLE_RPM="ansible"
174+
else
175+
ANSIBLE_RPM="ansible-$ANSIBLE_VERSION"
176+
fi
177+
retry yum -y $extra_opts install ${ANSIBLE_RPM} ||
171178
notify_failure "could not install ansible"
172179

173180
if [ -n "$OPENSHIFT_ANSIBLE_GIT_URL" -a -n "$OPENSHIFT_ANSIBLE_GIT_REV" ]; then

openshift.yaml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,14 @@ parameters:
2121
description: >
2222
The version of OpenStack Platform to use to collect data
2323
24+
# Allow the caller to specify the version of ansible
25+
ansible_version:
26+
type: string
27+
default: ""
28+
description: >
29+
Set the RPM version of Ansible that will run on the bastion
30+
If empty, use the current version
31+
2432
# Access to the VMs
2533
ssh_user:
2634
type: string
@@ -536,6 +544,7 @@ resources:
536544
properties:
537545
ocp_version: {get_param: ocp_version}
538546
osp_version: {get_param: osp_version}
547+
ansible_version: {get_param: ansible_version}
539548
image: {get_param: bastion_image}
540549
flavor: {get_param: bastion_flavor}
541550
key_name: {get_param: ssh_key_name}

0 commit comments

Comments
 (0)