Skip to content

Commit 1534498

Browse files
committed
Remove node's contraints
Any cotnraint causes that heat does an external API call when validating the stack (on any update/create operation). This is a big problem for large deployments, e.g. 6 contraints took ~6 seconds per single node -> with 50 nodes it took 5 mins to only validate because validation is sequential. These params are validated in the top-level openshift.yaml templates so it's safe to remove them to speed things up.
1 parent a195399 commit 1534498

1 file changed

Lines changed: 0 additions & 17 deletions

File tree

node.yaml

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -18,50 +18,36 @@ parameters:
1818
description: >
1919
A pre-submitted SSH key to access the VM hosts
2020
type: string
21-
constraints:
22-
- custom_constraint: nova.keypair
2321

2422
image:
2523
description: >
2624
Select a base image to use for the bastion server
2725
type: string
28-
constraints:
29-
- custom_constraint: glance.image
3026

3127
flavor:
3228
description: >
3329
Define the hardware characteristics for the VMs: CPU, Memory, base disk
3430
type: string
35-
constraints:
36-
- custom_constraint: nova.flavor
3731

3832
fixed_network:
3933
description: >
4034
The name or ID of the admin and public network
4135
type: string
42-
constraints:
43-
- custom_constraint: neutron.network
4436

4537
fixed_subnet:
4638
description: >
4739
The name or ID of the admin and public IPv4 space
4840
type: string
49-
constraints:
50-
- custom_constraint: neutron.subnet
5141

5242
internal_network:
5343
description: >
5444
The name or ID of the internal network
5545
type: string
56-
constraints:
57-
- custom_constraint: neutron.network
5846

5947
internal_subnet:
6048
description: >
6149
The name or ID of the internal IPv4 space
6250
type: string
63-
constraints:
64-
- custom_constraint: neutron.subnet
6551

6652
security_group:
6753
description: >
@@ -126,9 +112,6 @@ parameters:
126112
A string to identify node hostnames. Each node will also have a
127113
unique random substring attached
128114
type: string
129-
constraints:
130-
- allowed_pattern: '[a-z0-9\-]*'
131-
description: Hostname must contain only characters [a-z0-9\-].
132115

133116
domain_name:
134117
description: >

0 commit comments

Comments
 (0)