Call setInstalled() in fake install method

dgolovin · dgolovin · commit 29ddc13f4a43 · 2018-04-10T01:25:40.000-07:00
diff --git a/browser/services/componentLoader.js b/browser/services/componentLoader.js
@@ -91,7 +91,7 @@ class DynamicClass {
     let klass = require(`../${modulePath}`);
     let obj = klass.default.convertor.fromJson(config);
     if(skipInstall) {
-      obj.installAfterRequirements = skipInstallation.bind(this);
+      obj.installAfterRequirements = skipInstallation.bind(obj);
       obj.checkFiles = skipOperation.bind(this);
       obj.useDownload = false;
     }
@@ -101,6 +101,7 @@ class DynamicClass {
 
 function skipInstallation(progress, success) {
   progress.setStatus('Installing');
+  this.setInstallComplete();
   success && success(true);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,7 @@ class DynamicClass {`
`91`	`91`	let klass = require(`../${modulePath}`);
`92`	`92`	`let obj = klass.default.convertor.fromJson(config);`
`93`	`93`	`if(skipInstall) {`
`94`		`- obj.installAfterRequirements = skipInstallation.bind(this);`
	`94`	`+ obj.installAfterRequirements = skipInstallation.bind(obj);`
`95`	`95`	`obj.checkFiles = skipOperation.bind(this);`
`96`	`96`	`obj.useDownload = false;`
`97`	`97`	`}`
`@@ -101,6 +101,7 @@ class DynamicClass {`
`101`	`101`
`102`	`102`	`function skipInstallation(progress, success) {`
`103`	`103`	`progress.setStatus('Installing');`
	`104`	`+ this.setInstallComplete();`
`104`	`105`	`success && success(true);`
`105`	`106`	`}`
`106`	`107`