Set progress to installing at the start of vbox installation

Author: jrichter1

browser/model/virtualbox.js

@@ -123,6 +123,7 @@ class VirtualBoxInstallWindows extends VirtualBoxInstall {
   }
 
   installAfterRequirements(progress, success, failure) {
+    progress.setStatus('Installing');
     let installer = new Installer(this.keyName, progress, success, failure);
     return this.importCertificate(installer
     ).catch((error) => {
@@ -165,7 +166,6 @@ class VirtualBoxInstallWindows extends VirtualBoxInstall {
   }
 
   installMsi(installer, resolve, reject) {
-    installer.progress.setStatus('Installing');
     let msiFile = path.join(this.installerDataSvc.virtualBoxDir(), '/VirtualBox-' + this.version + '-r' + this.revision + '-MultiArch_amd64.msi');
     return installer.exec(['msiexec',
       '/i',

test/unit/model/virtualbox-test.js

@@ -162,6 +162,19 @@ describe('Virtualbox installer', function() {
         installer.ipcRenderer = {on: function() {}};
       });
 
+
+    it('should set progress to "Installing"', function() {
+      sandbox.stub(Installer.prototype, 'exec').resolves();
+      sandbox.stub(installer, 'configure').resolves();
+      sandbox.stub(Platform, 'addToUserPath').resolves();
+
+      return installer.installAfterRequirements(fakeProgress, success, failure)
+        .then(() => {
+          expect(fakeProgress.setStatus).to.have.been.calledOnce;
+          expect(fakeProgress.setStatus).to.have.been.calledWith('Installing');
+        });
+    });
+
       it('should import the certificate from the executable', function() {
         sandbox.stub(child_process, 'execFile').yields('done');
 
@@ -214,13 +227,6 @@ describe('Virtualbox installer', function() {
           reject = (argument) => { Promise.reject(argument); };
         });
 
-        it('should set progress to "Installing"', function() {
-          installer.installMsi(helper, resolve, reject);
-
-          expect(fakeProgress.setStatus).to.have.been.calledOnce;
-          expect(fakeProgress.setStatus).to.have.been.calledWith('Installing');
-        });
-
         it('should execute the msi installer', function() {
           let spy = sandbox.spy(Installer.prototype, 'exec');