(chore) reviews and fixes

Author: kameshsampath

basics/greeter-v1-service.yaml

@@ -5,16 +5,13 @@ metadata:
 spec:
   template:
     metadata:
-      name: greeter-v2
+      name: greeter-v1
     spec:
       containers:
-      - image: quay.io/rhdevelopers/knative-tutorial-greeter:quarkus
-        env:
-        - name: MESSAGE_PREFIX
-          value: Namaste
-        livenessProbe:
-          httpGet:
-            path: /healthz
-        readinessProbe:
-          httpGet:
-            path: /healthz
+        - image: quay.io/rhdevelopers/knative-tutorial-greeter:quarkus
+          livenessProbe:
+            httpGet:
+              path: /healthz
+          readinessProbe:
+            httpGet:
+              path: /healthz

basics/greeter-v2-service.yaml

@@ -9,6 +9,9 @@ spec:
     spec:
       containers:
       - image: quay.io/rhdevelopers/knative-tutorial-greeter:quarkus
+        env:
+        - name: MESSAGE_PREFIX
+          value: Namaste
         livenessProbe:
           httpGet:
             path: /healthz

bin/start-minikube.sh

@@ -15,8 +15,9 @@ ServiceAccount,\
 DefaultStorageClass,\
 MutatingAdmissionWebhook"
 
-minikube profile $PROFILE_NAME
-minikube start --memory=$MEMORY --cpus=$CPUS \
+minikube start -p $PROFILE_NAME \
+  --memory=$MEMORY \
+  --cpus=$CPUS \
   --kubernetes-version=v1.15.0 \
   --disk-size=50g \
   --extra-config="$EXTRA_CONFIG" \