Skip to content

Commit 0e34a48

Browse files
committed
More fixes for typos
1 parent ea8204b commit 0e34a48

9 files changed

Lines changed: 23 additions & 23 deletions

File tree

documentation/modules/ROOT/pages/01-setup.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ The following CLI tools are required for running the exercises in this tutorial.
2121

2222
| `git`
2323
| https://git-scm.com/download/mac
24-
| dnf install git
24+
| `dnf install git`
2525
|
2626

2727
| https://maven.apache.org[Apache Maven]

documentation/modules/ROOT/pages/02-basic-fundas.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ NOTE: Sometimes the response might not be returned immediately especially when t
8888
[#basics-see-what-you-have-deployed]
8989
== See what you have deployed
9090

91-
The service based deployment strategy that we did now will create many knative resources, the following commands will help you to query and find what has been deployed.
91+
The service-based deployment strategy that we did now will create many Knative resources, the following commands will help you to query and find what has been deployed.
9292

9393
[#basics-show-knative-services]
9494
=== service

documentation/modules/ROOT/pages/04-scaling.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,7 @@ oc -n knative-serving get configmap config-autoscaler -o yaml \
234234
| yq r - data.scale-to-zero-grace-period
235235
----
236236

237-
For better clarity and understanding let us <<scaling-cleanup,clean up>> the deployed knative resources before going to next section.
237+
For better clarity and understanding let us <<scaling-cleanup,clean up>> the deployed Knative resources before going to next section.
238238

239239
[#scaling-auto-scaling]
240240
== Auto Scaling

documentation/modules/ROOT/pages/05-build/build-templates.adoc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@ The raw builds like what we did in xref:ROOT:05-build/build.adoc[previous chapte
77
* Hard coding of build parameters
88
* Inability to make builds and services in synchronous i.e. services are deployed only after the related build is complete
99

10-
One of the solution to these problems is by using **Build Templates**.
10+
One of the solutions to these problems is **Build Templates**.
1111

12-
Like the build spec the knative build template spec and knative service spec also needs some customizations before apply them.
12+
Similarly to the build spec, the Knative build template spec and the Knative service spec needs some customizations before being applied.
1313

1414
[#build-template-prerequisite]
1515
== Prerequisite

documentation/modules/ROOT/pages/05-build/build.adoc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ Its required that you have container registry account which is needed during the
1919
You can get one for free at https://hub.docker.com[Docker Hub]
2020
====
2121

22-
As the Knative build and build template spec needs some customizations,such as creating a secret with your container registry credentials; we need to run following commands to create the needed kubernetes and knative resources with all your customizations. All the generated files will be placed in `$TUTORIAL_HOME/04-build/knative`.
22+
As the Knative build and build template specs need some customizations, such as creating a secret with your container registry credentials; we need to run the following commands to create the needed kubernetes and Knative resources with all your customizations. All the generated files will be placed in `$TUTORIAL_HOME/04-build/knative`.
2323

2424
[#build-create-docker-secret]
2525
== Generate Docker Secret
@@ -76,7 +76,7 @@ For more details on why we need to do this please check https://github.com/knati
7676

7777
[#build-generate-build-spec]
7878
== Generate Knative build spec
79-
The knative build spec is used to create and run the knative builds. You can find more details on Knative build https://github.com/knative/docs/tree/master/docs/build[here].
79+
The Knative build spec is used to create and run the Knative builds. You can find more details on Knative build https://github.com/knative/docs/tree/master/docs/build[here].
8080

8181
[source,bash,subs="+macros,+attributes",linenums]
8282
----
@@ -223,7 +223,7 @@ oc apply -n knativetutorial -f link:{github-repo}/{build-repo}/knative/kaniko-pv
223223

224224

225225
<1> The kubernetes secret called `basic-auth-pass`, check https://github.com/knative/docs/blob/master/docs/build/auth.md#basic-authentication-docker[here] for more details
226-
<2> The kubernetes service account called `build-bot` that wll run the build. Only `build-bot` has access to the secret `basic-auth-pass`. Check https://github.com/knative/docs/blob/master/docs/build/auth.md#basic-authentication-docker[here] for more details
226+
<2> The kubernetes service account called `build-bot` that will run the build. Only `build-bot` has access to the secret `basic-auth-pass`. Check https://github.com/knative/docs/blob/master/docs/build/auth.md#basic-authentication-docker[here] for more details
227227
<3> the kubernetes persistence volume claim used to cache maven artifacts, to make subsequent builds faster
228228
<4> the kubernetes persistence volume claim that will be used to cache docker base images to make subsequent https://github.com/GoogleContainerTools/kaniko[Kaniko] docker builds faster
229229

documentation/modules/ROOT/pages/06-eventing/eventing-src-sub.adoc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@ spec:
2222
name: in-memory-channel
2323
----
2424

25-
<1> The name of the channel, knative make it addressable i.e. resolveable to a target (a consumer service)
26-
<2> The channel provisioner which is responsible to provision this channel.Various messaging implementations provide their own channel(s) via __ClusterChannelProvisioner__.
25+
<1> The name of the channel. Knative makes it addressable, i.e. resolveable to a target (a consumer service)
26+
<2> The channel provisioner which is responsible for provisioning this channel. Various messaging implementations provide their own channel(s) via __ClusterChannelProvisioner__.
2727

2828
Navigate to tutorial chapter's `knative` folder:
2929

documentation/modules/ROOT/pages/06-eventing/eventing-src-svc.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ Navigate to tutorial chapter's `templates` folder:
114114
cd $TUTORIAL_HOME/05-eventing/knative/templates
115115
----
116116

117-
Run the following command to create the knative service that will be used as the subscriber for the cron events:
117+
Run the following command to create the Knative service that will be used as the subscriber for the cron events:
118118

119119
[source,bash,subs="+macros,+attributes",linenums]
120120
----

documentation/modules/ROOT/pages/_partials/minikube-setup.adoc

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
[#start-minikube]
55
==== Configure and Start minikube
66

7-
Before installing Knative and its components, we need to add few startup config to minikube.
7+
Before installing Knative and its components, we need to create the minikube virtual machine and deploy Kubernetes into it:
88

99
[source,bash,subs="+macros,+attributes"]
1010
----
@@ -20,7 +20,7 @@ minikube start -p knative --memory=8192 --cpus=4 \#<2>
2020
<1> Setting minikube profile to **knative** so that all future minikube commands are executed with this profile context
2121
<2> Starting a profile named **knative**
2222
<3> Minimum kubernetes version needs to be >= 1.12.0, refer to issue https://github.com/knative/serving/issues/3067 for more details.
23-
<4> If you are on linux then use `--vm-driver=kvm2`
23+
<4> On macOS. On Linux, please use `--vm-driver=kvm2`
2424

2525

2626
[#install-knative-istio]
@@ -34,15 +34,15 @@ kubectl apply --filename {knative-serving-repo}/{knative-serving-version}/istio.
3434

3535
[NOTE]
3636
====
37-
Installation of istio components will take some time and its highly recommended that you start Knative components installation only after you see all istio component pods are running. The istio pods can be watched using the command:
37+
Installation of istio components will take some time and it is highly recommended that you start Knative components installation only after you have verified that all istio component pods are running. The istio pods can be watched using the command:
3838
[source,bash,subs="+macros,+attributes"]
3939
----
4040
kubectl -n istio-system get pods -w
4141
----
4242
You can use kbd:[CTRL + c ] to terminate the watch
4343
====
4444

45-
A successful istio install will have the pods running in `istio-system` namespace as shown below:
45+
A successful istio install will have the pods running in the `istio-system` namespace as shown below:
4646

4747
[source,bash]
4848
----
@@ -73,15 +73,15 @@ kubectl apply --filename {knative-serving-repo}/{knative-serving-version}/servin
7373

7474
[NOTE]
7575
====
76-
Installation of knative serving components will take some time, the status of the knative serving pods can be watched using the command:
76+
As the Knative serving components are getting installed, you can watch their status using the following command:
7777
[source,bash,subs="+macros,+attributes"]
7878
----
7979
kubectl -n knative-serving get pods -w
8080
----
8181
You can use kbd:[CTRL + c ] to terminate the watch
8282
====
8383

84-
A successful Knative serving install will have the pods running in `knative-serving` as shown below:
84+
A successful Knative serving installation will have its pods running in the `knative-serving` namespace as shown below:
8585

8686
[source,bash]
8787
----
@@ -102,15 +102,15 @@ kubectl apply --filename {knative-build-repo}/{knative-build-version}/build.yaml
102102

103103
[NOTE]
104104
====
105-
Installation of knative build components will take some time, the status of the knative serving pods can be watched using the command:
105+
As the Knative build components are getting installed, you can watch their status using the following command:
106106
[source,bash,subs="+macros,+attributes"]
107107
----
108108
kubectl -n knative-build get pods -w
109109
----
110110
You can use kbd:[CTRL + c ] to terminate the watch
111111
====
112112

113-
A successful Knative build install will have the pods running in `knative-build` as shown below:
113+
A successful Knative build installation will have its pods running in the `knative-build` namespace as shown below:
114114

115115
[source,bash]
116116
----
@@ -131,7 +131,7 @@ kubectl apply --filename https://raw.githubusercontent.com/knative/serving/{knat
131131

132132
[NOTE]
133133
====
134-
Installation of knative eventing components will take some time, the status of the knative serving pods can be watched using the command:
134+
As the Knative eventing components are getting installed, you can watch their status using the following commands:
135135
[source,bash,subs="+macros,+attributes"]
136136
----
137137
kubectl -n knative-sources get pods -w
@@ -140,7 +140,7 @@ kubectl -n knative-eventing get pods -w
140140
You can use kbd:[CTRL + c ] to terminate the watch
141141
====
142142

143-
A successful Knative eventing install will have the pods running `knative-eventing` and `knative-sources` in as shown below:
143+
A successful Knative eventing installation will have the following pods running in the `knative-eventing` and `knative-sources` namespaces:
144144

145145
.knative-eventing namespace
146146

@@ -173,7 +173,7 @@ kubectl create namespace knativetutorial
173173

174174
[TIP]
175175
====
176-
kubens utility installed as part of https://github.com/ahmetb/kubectx[kubectx], allows change the kubernetes namespace easily.
176+
The kubens utility installed as part of https://github.com/ahmetb/kubectx[kubectx] allows for easy switching between kubernetes namespaces.
177177
178178
[source,bash]
179179
----

documentation/modules/ROOT/pages/_partials/openshift-setup.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ Run the following commands to configure Knative with minishift:
3434
./etc/scripts/install-on-minishift.sh #<1>
3535
-----
3636

37-
<1> It will create a minishift profile and install knative. It also assumes that you already have minishift and your computer has 10GB or more of memory
37+
<1> It will create a minishift profile and install Knative. It also assumes that you already have minishift and your computer has 10GB or more of memory.
3838

3939
[#configure-openshift-project]
4040
==== Configuring OpenShift project for Knative applications

0 commit comments

Comments
 (0)