fix lint issues

Author: recursivezero

app/api/fast_api.py

@@ -2,13 +2,12 @@
 import re
 import traceback
 from datetime import datetime, timezone
+from typing import TYPE_CHECKING
 
 from fastapi import APIRouter, FastAPI, Request
 from fastapi.responses import HTMLResponse, JSONResponse
 from pydantic import BaseModel, Field
 
-from typing import TYPE_CHECKING
-
 if TYPE_CHECKING:
     from pymongo.errors import PyMongoError
 else:
@@ -155,7 +154,7 @@ def shorten_url(payload: ShortenRequest):
             },
         )
 
-    if db_data.urls is None:
+    if db_data.collection is None:
         cached_short = get_short_from_cache(original_url)
         short_code = cached_short or generate_code()
         set_cache_pair(short_code, original_url)
@@ -167,7 +166,7 @@ def shorten_url(payload: ShortenRequest):
         }
 
     try:
-        existing = db_data.urls.find_one({"original_url": original_url})
+        existing = db_data.collection.find_one({"original_url": original_url})
     except PyMongoError:
         existing = None
 
@@ -181,7 +180,7 @@ def shorten_url(payload: ShortenRequest):
 
     short_code = generate_code()
     try:
-        db_data.urls.insert_one(
+        db_data.collection.insert_one(
             {
                 "short_code": short_code,
                 "original_url": original_url,

app/main.py

@@ -12,13 +12,13 @@
 from app.utils import data as db_data
 from app.utils.cache import (
     get_from_cache,
-    get_short_from_cache,
     get_recent_from_cache,
+    get_short_from_cache,
     rev_cache,
     set_cache_pair,
     url_cache,
 )
-from app.utils.config import load_env, SESSION_SECRET, DOMAIN, MAX_RECENT_URLS
+from app.utils.config import DOMAIN, MAX_RECENT_URLS, SESSION_SECRET, load_env
 from app.utils.helper import (
     format_date,
     generate_code,
@@ -27,13 +27,14 @@
 )
 from app.utils.qr import generate_qr_with_logo
 
+load_env()
+
 
 # -----------------------------
 # Lifespan: env + DB connect ONCE
 # -----------------------------
 @asynccontextmanager
 async def lifespan(app: FastAPI):
-    load_env()
     db_data.connect_db()
     yield
 
@@ -118,27 +119,40 @@ async def create_short_url(
         )
         return RedirectResponse("/", status_code=303)
 
-    cached_short = get_short_from_cache(original_url)
-    if cached_short:
-        short_code = cached_short
+    # 1. Try Cache First
+    short_code: Optional[str] = get_short_from_cache(original_url)
+
+    if short_code:
         session["info_message"] = "Already shortened before — fetched from cache."
     else:
-        short_code = None
-
+        # 2. Try Database
         existing = db_data.find_by_original_url(original_url)
-        if existing:
-            short_code = existing["short_code"]
-            set_cache_pair(short_code, original_url)
+        # Pull the value and check it in one go
+        db_code = existing.get("short_code") if existing else None
+        if isinstance(db_code, str):
+            short_code = db_code
+            set_cache_pair(short_code, original_url)  # Cache it for future
             session["info_message"] = (
                 "Already shortened before — fetched from database."
             )
 
+        # 3. Generate New if still None
         if not short_code:
             short_code = generate_code()
             set_cache_pair(short_code, original_url)
             db_data.insert_url(short_code, original_url)
 
+    # --- TYPE GUARD FOR MYPY ---
+    # At this point, short_code could still technically be Optional[str]
+    # if generate_code() wasn't strictly typed. We cast or assert.
+    if not isinstance(short_code, str):
+        # This acts as a final safety net for production
+        session["error"] = "Internal server error: Code generation failed."
+        return RedirectResponse("/", status_code=303)
+
+    # Mypy now knows short_code is strictly 'str'
     new_short_url = build_short_url(short_code, str(request.base_url))
+
     session.update(
         {
             "new_short_url": new_short_url,
@@ -201,8 +215,7 @@ async def redirect_short(request: Request, short_code: str):
     if doc:
         set_cache_pair(short_code, doc["original_url"])
         return RedirectResponse(doc["original_url"])
-
-    if not db_data.get_collection():
+    if db_data.get_collection() is None:
         return PlainTextResponse("Database is not connected.", status_code=503)
 
     return PlainTextResponse("Invalid or expired short URL", status_code=404)

app/static/css/tiny.css

@@ -10,7 +10,7 @@
 body {
   background: var(--bg);
   color: var(--text-primary);
-  font-family: 'Inter', system-ui, sans-serif;
+  font-family: "Inter", system-ui, sans-serif;
   margin: 0;
   overflow-x: hidden;
   background-image: radial-gradient(circle at 50% -20%, #1e1e2e 0%, transparent 50%);
@@ -24,6 +24,7 @@ body {
   flex-direction: column;
   align-items: center;
   gap: 2rem;
+  min-height: 52vh;
 }
 
 /* --- LARGE HERO INPUT --- */
@@ -205,4 +206,51 @@ body {
   .footer-grid {
     grid-template-columns: 1fr 1fr;
   }
-}
+}
+
+/* The container for the icon/button */
+.copy-btn {
+  position: relative;
+  cursor: pointer;
+  transition: transform 0.1s ease;
+}
+
+.copy-btn:active {
+  transform: scale(0.9);
+}
+
+/* The "Smart" Tooltip */
+.copy-btn.copy-success::after {
+  content: attr(data-tooltip);
+  position: absolute;
+  top: -30px;
+  left: 50%;
+  transform: translateX(-50%);
+  background: #333;
+  color: #fff;
+  padding: 4px 8px;
+  border-radius: 4px;
+  font-size: 12px;
+  white-space: nowrap;
+  animation: fadeInOut 2s forwards;
+}
+
+@keyframes fadeInOut {
+  0% {
+    opacity: 0;
+    transform: translate(-50%, 5px);
+  }
+
+  15% {
+    opacity: 1;
+    transform: translate(-50%, 0);
+  }
+
+  85% {
+    opacity: 1;
+  }
+
+  100% {
+    opacity: 0;
+  }
+}

app/templates/index.html

@@ -39,12 +39,17 @@ <h1>tiny URL</h1>
       </div>
     </div>
     <div style="display: flex; flex-direction: column; gap: 0.5rem;">
-      <button onclick="copyLink()" class="btn-copy"
-        style="background: rgba(255,255,255,0.05); border: 1px solid var(--glass-border); color: white; padding: 0.8rem 1.5rem; border-radius: 1rem; cursor: pointer;">Copy
-        Link</button>
-      {% if qr_image %}<a href="{{ qr_image }}" download
-        style="text-align: center; font-size: 0.7rem; color: var(--text-secondary); text-decoration: none;">Download
-        QR</a>{% endif %}
+      <button onclick="copyLink(this)" data-url="{{ new_short_url }}" class="btn-copy"
+        style="background: rgba(255,255,255,0.05); border: 1px solid var(--glass-border); color: white; padding: 0.8rem 1.5rem; border-radius: 1rem; cursor: pointer; position: relative;">
+        Copy Link
+      </button>
+
+      {% if qr_image %}
+      <a href="{{ qr_image }}" download
+        style="text-align: center; font-size: 0.7rem; color: var(--text-secondary); text-decoration: none;">
+        Download QR
+      </a>
+      {% endif %}
     </div>
   </div>
   {% endif %}
@@ -113,10 +118,30 @@ <h4>Legal</h4>
 </footer>
 
 <script>
-  function copyLink() {
-    const text = document.getElementById('shortUrlDisplay').innerText;
-    navigator.clipboard.writeText(text);
-    alert('Copied to clipboard!');
+  async function copyLink(btn) {
+    // Get the dynamic value from the data attribute
+    const url = btn.getAttribute('data-url');
+    const originalText = btn.innerText;
+
+    try {
+      await navigator.clipboard.writeText(url);
+
+      // Visual feedback: Change text and style
+      btn.innerText = 'Copied!';
+      btn.style.borderColor = '#4ade80'; // A subtle green (Tailwind-like)
+      btn.style.color = '#4ade80';
+
+      // Reset after 2 seconds
+      setTimeout(() => {
+        btn.innerText = originalText;
+        btn.style.borderColor = 'var(--glass-border)';
+        btn.style.color = 'white';
+      }, 2000);
+
+    } catch (err) {
+      console.error('Copy failed', err);
+      // Fallback if needed
+    }
   }
 </script>
 {% endblock %}