Rules that are not registered in the config are executed

[CybotTM]

Bug Report

Subject	Details
Rector version	rector-src 820c9dad

tests/Issues/Issue9388 in this repository registers two rules. Three run.

Minimal PHP Code Causing Issue

Boot tests/Issues/Issue9388/config/configured_rule.php and ask the container:

findByContract(RectorInterface::class):  RenameClassRector, ExtbaseAnnotationToAttributeRector, StringClassNameToClassConstantRector
getMainRectorClasses():                  RenameClassRector, ExtbaseAnnotationToAttributeRector

StringClassNameToClassConstantRector is never registered by that config. It runs against every fixture of the test.

Expected Behaviour

Only registered rules run.

Filing this as an issue rather than a PR — rectorphp/rector-src#8402 was closed — so someone else can pick up a patch.

[TomasVotruba]

Thank you for your report!

We'll need an isolated failing demo link from: http://getrector.com/demo,
that way we can reproduce the bug.

[CybotTM]

The demo applies a chosen rule to a code snippet, but this bug is about which rules run at all, which the config decides — there is no place in the demo to register a service that holds a rule, so it cannot show it.

An isolated failing test is in rectorphp/rector-src#8402: testRuleTakenOnlyAsDependencyIsNotActive in tests/Config/RectorConfigTest.php, with tests/Config/Source/RegisteringRector.php and DependencyOnlyRector.php. Applying only those three files to main and running vendor/bin/phpunit tests/Config/RectorConfigTest.php:

Failed asserting that an array does not contain 'Rector\Tests\Config\Source\DependencyOnlyRector'.

[TomasVotruba]

That looks like test case hacking to me. We'll need a standard failing test case, not on Rector internals.
We run 100+ of rule test with different configuration in here, so if they would be pilling up, it would show.

[TomasVotruba]

The $registeredRectorClasses cleanup happens couple lines above in:

$this->forgetRectorsRules();

[CybotTM]

H @TomasVotruba,

We run 100+ of rule test with different configuration in here, so if they would be pilling up, it would show.

what do you mean by "it would"? It does, in your own test tests/Issues/Issue9388

Whatever, fine for me. Do whatever you want, tried my best.
You rejected the long explanation, and it required a long explanation, because it is tricky.

I don't argue with you over this project and whether there is a bug or not.
I tried to provide a fix, I tried to report it.
I tried to provide an exhaustive explanation.
Dunno how I can help here any further.

Running a config with 2 registered rules, and get 3 rules executed is a bug to me.

If I am wrong here, just close the bug report.

[CybotTM]

On current main (cc5d6f984f), two identical lines added to the existing fixture — one per half — make tests/Issues/Issue9388 fail:

--- a/tests/Issues/Issue9388/Fixture/fixture.php.inc
+++ b/tests/Issues/Issue9388/Fixture/fixture.php.inc
@@ -14,6 +14,8 @@ final class MyClass
      * @TYPO3\CMS\Extbase\Annotation\Validate("NotEmpty")
      */
     protected $thisWorks = '';
+
+    protected $className = 'Rector\Config\RectorConfig';
 }
 -----
 <?php
@@ -30,4 +32,6 @@ final class MyClass
 
     #[\TYPO3\CMS\Extbase\Annotation\Validate(['validator' => 'NotEmpty'])]
     protected $thisWorks = '';
+
+    protected $className = 'Rector\Config\RectorConfig';
 }

vendor/bin/phpunit tests/Issues/Issue9388 --no-progress

There was 1 failure:

1) Rector\Tests\Issues\Issue9388\Issue9388Test::test@…/tests/Issues/Issue9388/Fixture/fixture.php.inc with data ('…hp.inc')
Failed on fixture file "fixture.php.inc"

Applied Rector rules:
 * Rector\Php55\Rector\String_\StringClassNameToClassConstantRector
 * Rector\Tests\Issues\Issue9388\Source\Rule\ExtbaseAnnotationToAttributeRector

Failed asserting that string matches format description.
--- Expected
+++ Actual
@@ @@
     #[\TYPO3\CMS\Extbase\Annotation\Validate(['validator' => 'NotEmpty'])]
     protected $thisWorks = '';
 
-    protected $className = 'Rector\Config\RectorConfig';
+    protected $className = \Rector\Config\RectorConfig::class;
 }

FAILURES!
Tests: 1, Assertions: 3, Failures: 1.

StringClassNameToClassConstantRector is listed under the applied rules. tests/Issues/Issue9388/config/configured_rule.php registers RenameClassRector and ExtbaseAnnotationToAttributeRector — never that one. It is built because the config registers ValidateAttributeDecorator, which takes it as a constructor dependency.

The existing fixture does not show this because the rule skips strings without a backslash, with a lowercase first letter, or naming a class the reflection provider does not know — 'NotEmpty' fails all three.

Applying only the src/Config/RectorConfig.php part of rectorphp/rector-src#8402 to the same tree turns the test green again.

[TomasVotruba]

We'll need a failing reproducer, and human input. I closed rectorphp/rector-src#8402 because description was without any human touch, 500+ lines of AI slop. Some answers here seems copy-pasted from chatbot as well, without answer my remarks.

If you want to fix/report a bug here, you'll need to understand code and be here. Copy-pasting back and forth to GPT is not acceptable.