System error: "Rector\DeadCode\ConditionResolver::resolveArgumentValue(): Return value must be of type ?int, float returned"

[ziegenberg]

Bug Report

Subject	Details
Rector version	ff8b25

Minimal PHP Code Causing Issue

https://getrector.com/demo/fd6ffcf5-7c7f-420e-91ec-3257a6ad5705

Expected Behaviour

Rector should also handle type juggling floats to string.

$result = version_compare(PHP_VERSION, 7.3, '>=') ? "yay" : "nay";

The second argument to version_compare is type converted from float to string.

[ziegenberg]

Found this while running Rector on the Matomo source. See: https://github.com/matomo-org/matomo/blob/aa87d451890e3f2cd7fc85790cb2911a737e105c/plugins/API/tests/Unit/HtmlRendererTest.php#L279

[TomasVotruba]

Thanks for reporting 👍 Fixed in rectorphp/rector-src#8192

In ~3 mins new version on dev-main will be deployed. Can you verify it works well for you? I want to make sure this is fixed before making any releases

[ziegenberg]

That was quick!

$ vendor/bin/rector --version
Rector a585be1359f0cf4f428db478af31d89f05c5b2ed

Now it works.