Incorrect behavior of ArrayToFirstClassCallableRector

[samsonasik]

Bug Report

Subject	Details
Rector version	last dev-main
Installed as	composer dependency

Minimal PHP Code Causing Issue

See https://getrector.com/demo/faa93c4d-6f7b-4c81-9f36-31a20f50e461

<?php

final class DemoFile
{
    public function run(array $data)
    {
    }

    public function execute()
    {
        return $this->run([$this, 'some']);
    }
    
    public function some()
    {}
}

Responsible rules

• ArrayToFirstClassCallableRector

Expected Behavior

When used as argument, and caller requires array as type data, it should be skipped, or it will cause error:

Fatal error: Uncaught TypeError: DemoFile::run(): Argument #1 ($data) must be of type array, Closure given, called in /in/9sEbL on line 11 and defined in /in/9sEbL:5

see https://3v4l.org/9sEbL#v8.1.34

[github-actions]

This issue has been automatically marked as stale due to inactivity. It will be closed in next 30 days if no further activity occurs.

[samsonasik]

Closing for now as used on multiple cases and some cases are valid.

[boesing]

What I do not understand is, why is rector relying on PHPStan yet it does not respect argument types identified by PHPStan?
If a method states "give me an array" instead of "give me a callable/closure", why would rector convert the code to a closure?

Maybe I do not get the point, but unless an argument where this value is passed is explicitly allowing a callable/closure, there should be no first class callable change applied?

[TomasVotruba]

Can you share a failing example on https://getrector.com/demo ?

[boesing]

Bad

https://getrector.com/demo/8a4d7859-70e5-4125-800e-7b264d066988

Fatal error: Uncaught TypeError: DemoFile::__construct(): Argument #1 ($argument) must be of type SomeObjectAsArgument|array|string|null, Closure given, called in /in/Jq0H4 on line 25 and defined in /in/Jq0H4:9
Stack trace:
#0 /in/Jq0H4(25): DemoFile->__construct(Object(Closure))
#1 {main}
  thrown in /in/Jq0H4 on line 9

Process exited with code 255.

Good

https://getrector.com/demo/70c3ac93-bd99-44d3-9a43-b9e1640c1ec8
https://getrector.com/demo/abad4892-25c4-4779-ba10-a10b2111413f

[TomasVotruba]

Got it! Thanks