Dry run combined with no diffs always exits with success code

[indykoning]

Bug Report

Subject	Details
Rector version	2.2.7

When running Rector for CI/CD purposes we run rector process --dry-run --ansi --no-progress-bar --no-diffs
However when --dry-run is added together with --no-diffs it will always result in [OK] Rector is done! with a success exit code.
even though changes should be made.

Removing --no-diffs will result in [OK] xx files would have been changed (dry-run) by Rector with a failure exit code, as expected.
However it also gives a massive diff which is not preferable for CI/CD.

[samsonasik]

For CI based, I think you can use github or gitlab formatter, eg --output-format=github, see PR:

• feat(ChangesReporting): add GitHub output formatter rector-src#6747

Also, try apply level by level so you will got less diff, see documentation

https://getrector.com/documentation/levels#content-one-level-at-a-time

[TomasVotruba]

Thanks for reporting. The exit code should be the same, regardless diff or no diff option.
Both runs should fail on CI. Any ideas where the --no-diff changes behavior?

[samsonasik]

@TomasVotruba this may cause by this diff check:

rector/src/Console/Command/ProcessCommand.php

Lines 213 to 216 in 531712b

	if ($processResult->getFileDiffs() !== []) {
	return ExitCode::CHANGED_CODE;
	}
	return ExitCode::SUCCESS;

to cover this, the File->hasChanged() at least one flag may need to be saved somewhere as no diff can be because of no file changed or the --no-diff is used.

[samsonasik]

I created PR kick off

• [Diffs] Handle --no-diffs usage to show file have been changed if any with --dry-run + --no-diffs rector-src#7619

for it.

[indykoning]

That was seriously fast! I'll give it a try, thank you! 🚀

[github-actions]

This issue has been automatically locked because it has been closed for 150 days. Please open a new issue if you have a similar problem.