Skip to content

Commit fc18e99

Browse files
OndraFiedlerOndraFiedler
committed
Fix sending false to the API in query parameters
1 parent 077e21f commit fc18e99

9 files changed

Lines changed: 26 additions & 23 deletions

‎README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ or
1717
```
1818
{
1919
"require": {
20-
"recombee/php-api-client": "^1.6.0"
20+
"recombee/php-api-client": "^1.6.1"
2121
}
2222
}
2323
```

‎src/RecommApi/Client.php‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ protected function getOptionalHttpHeaders() {
112112
}
113113

114114
protected function getHttpHeaders() {
115-
return array_merge(array('User-Agent' => 'recombee-php-api-client/1.6.0'), $this->getOptionalHttpHeaders());
115+
return array_merge(array('User-Agent' => 'recombee-php-api-client/1.6.1'), $this->getOptionalHttpHeaders());
116116
}
117117

118118
protected function getOptionalRequestOptions() {
@@ -212,6 +212,9 @@ protected function paramsToUrl($params) {
212212
protected function formatQueryParameterValue($value) {
213213
if (is_array($value))
214214
return implode(',', $value);
215+
if (is_bool($value))
216+
return ($value) ? 'true' : 'false';
217+
215218
else return $value;
216219
}
217220

‎src/RecommApi/Requests/RecommendItemsToItem.php‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ class RecommendItemsToItem extends Request {
6565
* Example response:
6666
* ```
6767
* {
68-
* "recommId": "8ac80708afe9148130528757ebf6aaba",
68+
* "recommId": "0c6189e7-dc1a-429a-b613-192696309361",
6969
* "recomms":
7070
* [
7171
* {
@@ -96,7 +96,7 @@ class RecommendItemsToItem extends Request {
9696
* Example response for `includedProperties=description,price`:
9797
* ```
9898
* {
99-
* "recommId": "c7dbfc503d262b80b77b4949ee9855fb",
99+
* "recommId": "6842c725-a79f-4537-a02c-f34d668a3f80",
100100
* "recomms":
101101
* [
102102
* {
@@ -183,7 +183,7 @@ class RecommendItemsToItem extends Request {
183183
* Example response:
184184
* ```
185185
* {
186-
* "recommId": "8ac80708afe9148130528757ebf6aaba",
186+
* "recommId": "0c6189e7-dc1a-429a-b613-192696309361",
187187
* "recomms":
188188
* [
189189
* {
@@ -213,7 +213,7 @@ class RecommendItemsToItem extends Request {
213213
* Example response for `includedProperties=description,price`:
214214
* ```
215215
* {
216-
* "recommId": "c7dbfc503d262b80b77b4949ee9855fb",
216+
* "recommId": "6842c725-a79f-4537-a02c-f34d668a3f80",
217217
* "recomms":
218218
* [
219219
* {

‎src/RecommApi/Requests/RecommendItemsToUser.php‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ class RecommendItemsToUser extends Request {
4545
* Example response:
4646
* ```
4747
* {
48-
* "recommId": "1644e7b31759a08480da5f3b0a13045b",
48+
* "recommId": "ce52ada4-e4d9-4885-943c-407db2dee837",
4949
* "recomms":
5050
* [
5151
* {
@@ -76,7 +76,7 @@ class RecommendItemsToUser extends Request {
7676
* Example response for `includedProperties=description,price`:
7777
* ```
7878
* {
79-
* "recommId": "e3ba43af1a4e59dd08a00adced1729a7",
79+
* "recommId": "a86ee8d5-cd8e-46d1-886c-8b3771d0520b",
8080
* "recomms":
8181
* [
8282
* {
@@ -147,7 +147,7 @@ class RecommendItemsToUser extends Request {
147147
* Example response:
148148
* ```
149149
* {
150-
* "recommId": "1644e7b31759a08480da5f3b0a13045b",
150+
* "recommId": "ce52ada4-e4d9-4885-943c-407db2dee837",
151151
* "recomms":
152152
* [
153153
* {
@@ -177,7 +177,7 @@ class RecommendItemsToUser extends Request {
177177
* Example response for `includedProperties=description,price`:
178178
* ```
179179
* {
180-
* "recommId": "e3ba43af1a4e59dd08a00adced1729a7",
180+
* "recommId": "a86ee8d5-cd8e-46d1-886c-8b3771d0520b",
181181
* "recomms":
182182
* [
183183
* {

‎src/RecommApi/Requests/RecommendUsersToItem.php‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ class RecommendUsersToItem extends Request {
4545
* Example response:
4646
* ```
4747
* {
48-
* "recommId": "9eeebc318508302529e3241f4570834d",
48+
* "recommId": "039b71dc-b9cc-4645-a84f-62b841eecfce",
4949
* "recomms":
5050
* [
5151
* {
@@ -72,7 +72,7 @@ class RecommendUsersToItem extends Request {
7272
* Example response for `includedProperties=country`:
7373
* ```
7474
* {
75-
* "recommId": "d4c826635efc3e01a83470008c5697f1",
75+
* "recommId": "b2b355dd-972a-4728-9c6b-2dc229db0678",
7676
* "recomms":
7777
* [
7878
* {
@@ -129,7 +129,7 @@ class RecommendUsersToItem extends Request {
129129
* Example response:
130130
* ```
131131
* {
132-
* "recommId": "9eeebc318508302529e3241f4570834d",
132+
* "recommId": "039b71dc-b9cc-4645-a84f-62b841eecfce",
133133
* "recomms":
134134
* [
135135
* {
@@ -155,7 +155,7 @@ class RecommendUsersToItem extends Request {
155155
* Example response for `includedProperties=country`:
156156
* ```
157157
* {
158-
* "recommId": "d4c826635efc3e01a83470008c5697f1",
158+
* "recommId": "b2b355dd-972a-4728-9c6b-2dc229db0678",
159159
* "recomms":
160160
* [
161161
* {
@@ -199,7 +199,7 @@ public function __construct($item_id, $count, $optional = array()) {
199199
if (!in_array($key, $existing_optional))
200200
throw new UnknownOptionalParameterException($key);
201201
}
202-
$this->timeout = 3000;
202+
$this->timeout = 50000;
203203
$this->ensure_https = false;
204204
}
205205

‎src/RecommApi/Requests/RecommendUsersToUser.php‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ class RecommendUsersToUser extends Request {
4545
* Example response:
4646
* ```
4747
* {
48-
* "recommId": "32fc671480eb29d843e47def43503992",
48+
* "recommId": "9cb9c55d-50ba-4478-84fd-ab456136156e",
4949
* "recomms":
5050
* [
5151
* {
@@ -72,7 +72,7 @@ class RecommendUsersToUser extends Request {
7272
* Example response for `includedProperties=country`:
7373
* ```
7474
* {
75-
* "recommId": "27d81ade643621f45cc6ba5d30d7d683",
75+
* "recommId": "b326d82d-5d57-4b45-b362-c9d6f0895855",
7676
* "recomms":
7777
* [
7878
* {
@@ -141,7 +141,7 @@ class RecommendUsersToUser extends Request {
141141
* Example response:
142142
* ```
143143
* {
144-
* "recommId": "32fc671480eb29d843e47def43503992",
144+
* "recommId": "9cb9c55d-50ba-4478-84fd-ab456136156e",
145145
* "recomms":
146146
* [
147147
* {
@@ -167,7 +167,7 @@ class RecommendUsersToUser extends Request {
167167
* Example response for `includedProperties=country`:
168168
* ```
169169
* {
170-
* "recommId": "27d81ade643621f45cc6ba5d30d7d683",
170+
* "recommId": "b326d82d-5d57-4b45-b362-c9d6f0895855",
171171
* "recomms":
172172
* [
173173
* {
@@ -223,7 +223,7 @@ public function __construct($user_id, $count, $optional = array()) {
223223
if (!in_array($key, $existing_optional))
224224
throw new UnknownOptionalParameterException($key);
225225
}
226-
$this->timeout = 3000;
226+
$this->timeout = 50000;
227227
$this->ensure_https = false;
228228
}
229229

‎tests/AddEntityTestCase.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ public function testAddEntity() {
2020
$resp = $this->client->send($req);
2121

2222
//it fails with invalid entity id
23-
$req = $this->createRequest('...not_valid...');
23+
$req = $this->createRequest('$$$not_valid$$$');
2424
try {
2525

2626
$this->client->send($req);

‎tests/DeleteEntityTestCase.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ public function testDeleteEntity() {
2929
}
3030

3131
//it fails with invalid entity id
32-
$req = $this->createRequest('...not_valid...');
32+
$req = $this->createRequest('$$$not_valid$$$');
3333
try {
3434

3535
$this->client->send($req);

‎tests/DeletePropertyTestCase.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ public function testDeleteProperty() {
2929
}
3030

3131
//it fails with invalid property
32-
$req = $this->createRequest('...not_valid...');
32+
$req = $this->createRequest('$$$not_valid$$$');
3333
try {
3434

3535
$this->client->send($req);

0 commit comments

Comments
 (0)