update Stream to throw exception on invalid passed to constructor

Author: steverhoades

src/Stream.php

@@ -4,6 +4,7 @@
 
 use Evenement\EventEmitter;
 use React\EventLoop\LoopInterface;
+use InvalidArgumentException;
 
 class Stream extends EventEmitter implements DuplexStreamInterface
 {
@@ -18,10 +19,12 @@ class Stream extends EventEmitter implements DuplexStreamInterface
     public function __construct($stream, LoopInterface $loop)
     {
         $this->stream = $stream;
-        if (is_resource($this->stream) && get_resource_type($this->stream) === "stream") {
-            stream_set_blocking($this->stream, 0);
+        if (!is_resource($this->stream) || get_resource_type($this->stream) !== "stream") {
+             throw new InvalidArgumentException('Invalid stream resource passed as the first argument to '. __METHOD__);
         }
 
+        stream_set_blocking($this->stream, 0);
+
         $this->loop = $loop;
         $this->buffer = new Buffer($this->stream, $this->loop);
 

tests/StreamTest.php

@@ -17,6 +17,16 @@ public function testConstructor()
         $conn = new Stream($stream, $loop);
     }
 
+    /**
+     * @covers React\Stream\Stream::__construct
+     */
+    public function testConstructorThrowsExceptionOnInvalidStream()
+    {
+        $this->setExpectedException('InvalidArgumentException');
+        $loop = $this->createLoopMock();
+        $conn = new Stream('breakme', $loop);
+    }
+
     /**
      * @covers React\Stream\Stream::__construct
      * @covers React\Stream\Stream::handleData
@@ -55,19 +65,6 @@ public function testWrite()
         $this->assertSame("foo\n", fgets($stream));
     }
 
-    /**
-     * @covers React\Stream\Stream::write
-     */
-    public function testWriteError()
-    {
-        $stream = "Silly developer, you can't write to to a string!";
-        $loop = $this->createWriteableLoopMock();
-
-        $conn = new Stream($stream, $loop);
-        $conn->on('error', $this->expectCallableOnce());
-        $conn->write('Attempting to write to a string');
-    }
-
     /**
      * @covers React\Stream\Stream::end
      */