Skip to content

Commit bd9b429

Browse files
committed
Update to Promise v2 API (while keeping full BC)
1 parent f9f63ee commit bd9b429

5 files changed

Lines changed: 7 additions & 26 deletions

File tree

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,6 @@
1818
"evenement/evenement": "~1.0|~2.0",
1919
"react/event-loop": ">=0.2, <0.5",
2020
"react/dns": ">=0.2, <0.5",
21-
"react/promise": "~1.0|~2.0"
21+
"react/promise": "~2.0|~1.1"
2222
}
2323
}

src/Factory.php

Lines changed: 5 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
use React\EventLoop\LoopInterface;
66
use React\Dns\Resolver\Resolver;
7-
use React\Promise\Deferred;
7+
use React\Promise;
88
use React\Datagram\Socket;
99
use \Exception;
1010

@@ -65,10 +65,7 @@ protected function resolveAddress($address)
6565
$parts = parse_url($address);
6666

6767
if (!$parts || !isset($parts['host'])) {
68-
$deferred = new Deferred();
69-
$deferred->resolve($address);
70-
71-
return $deferred->promise();
68+
return Promise\resolve($address);
7269
}
7370

7471
if ($nullport) {
@@ -100,24 +97,15 @@ protected function resolveHost($host)
10097
{
10198
// there's no need to resolve if the host is already given as an IP address
10299
if (false !== filter_var($host, FILTER_VALIDATE_IP)) {
103-
$deferred = new Deferred();
104-
$deferred->resolve($host);
105-
106-
return $deferred->promise();
100+
return Promise\resolve($host);
107101
}
108102
// todo: remove this once the dns resolver can handle the hosts file!
109103
if ($host === 'localhost') {
110-
$deferred = new Deferred();
111-
$deferred->resolve('127.0.0.1');
112-
113-
return $deferred->promise();
104+
return Promise\resolve('127.0.0.1');
114105
}
115106

116107
if ($this->resolver === null) {
117-
$deferred = new Deferred();
118-
$deferred->reject(new Exception('No resolver given in order to get IP address for given hostname'));
119-
120-
return $deferred->promise();
108+
return Promise\reject(new Exception('No resolver given in order to get IP address for given hostname'));
121109
}
122110

123111
return $this->resolver->resolve($host);

tests/FactoryTest.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
<?php
22

33
use React\Datagram\Socket;
4-
use React\Promise\When;
5-
use React\Promise\PromiseInterface;
64

75
class FactoryTest extends TestCase
86
{

tests/SocketTest.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
<?php
22

33
use React\Datagram\Socket;
4-
use React\Promise\When;
5-
use React\Promise\PromiseInterface;
64

75
class SocketTest extends TestCase
86
{

tests/bootstrap.php

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
<?php
22

3-
use React\Promise\When;
4-
use React\Promise\PromiseInterface;
5-
6-
require __DIR__.'/../vendor/autoload.php';
3+
require __DIR__ . '/../vendor/autoload.php';
74

85
abstract class TestCase extends PHPUnit_Framework_TestCase
96
{

0 commit comments

Comments
 (0)