Merge pull request #8 from clue/random-port

Automatically assign a random port for port 0

Author: clue

Datagram/Factory.php

@@ -54,12 +54,24 @@ protected function resolveAddress($address)
         if (strpos($address, '://') === false) {
             $address = 'udp://' . $address;
         }
+
+        // parse_url() does not accept null ports (random port assignment) => manually remove
+        $nullport = false;
+        if (substr($address, -2) === ':0') {
+            $address = substr($address, 0, -2);
+            $nullport = true;
+        }
+
         $parts = parse_url($address);
 
         if (!$parts || !isset($parts['host'])) {
             return When::resolve($address);
         }
 
+        if ($nullport) {
+            $parts['port'] = 0;
+        }
+
         // remove square brackets for IPv6 addresses
         $host = trim($parts['host'], '[]');
 

tests/FactoryTest.php

@@ -53,4 +53,16 @@ public function testCreateServer()
 
         $capturedServer->close();
     }
+
+    public function testCreateServerRandomPort()
+    {
+        $promise = $this->factory->createServer('127.0.0.1:0');
+
+        $capturedServer = $this->getValueFromResolvedPromise($promise);
+        $this->assertInstanceOf('Datagram\Socket', $capturedServer);
+
+        $this->assertNotEquals('127.0.0.1:0', $capturedServer->getLocalAddress());
+
+        $capturedServer->close();
+    }
 }