Turn on experimental.new_this_typing in xplat (#58293)

Summary:
Pull Request resolved: #58293

Changelog: [Internal]

Reviewed By: vzaidman

Differential Revision: D118513884

fbshipit-source-id: a33a81eab930ac29663410cf04163aebb87062ad

Author: SamChou19815

packages/dev-middleware/src/inspector-proxy/Device.js

@@ -500,6 +500,8 @@ export default class Device {
     // $FlowFixMe[cannot-write]
     socket.send = function (message: string) {
       cdpDebugLogging.log('ProxyToDebugger', message);
+      /* $FlowFixMe[invalid-this-arg] Error exposed after fixing this typing
+       * unsoundness in flow */
       return sendFunc.call(socket, message);
     };
   }

packages/react-native/Libraries/Animated/__tests__/AnimatedValue-itest.js

@@ -237,6 +237,8 @@ describe('AnimatedValue', () => {
       // $FlowFixMe[method-unbinding]
       const original = node.__onAnimatedValueUpdateReceived;
       const spy = jest.fn((...args: Array<unknown>) =>
+        /* $FlowFixMe[invalid-this-arg] Error exposed after fixing this typing
+         * unsoundness in flow */
         original.apply(node, args),
       );
       // $FlowFixMe[cannot-write]

packages/react-native/Libraries/Animated/nodes/AnimatedProps.js

@@ -384,4 +384,6 @@ export default class AnimatedProps extends AnimatedNode {
 const _hasOwnProp = Object.prototype.hasOwnProperty;
 const hasOwn: (obj: Readonly<{...}>, prop: string) => boolean =
   // $FlowFixMe[method-unbinding]
+  /* $FlowFixMe[invalid-this-arg] Error exposed after fixing this typing
+   * unsoundness in flow */
   Object.hasOwn ?? ((obj, prop) => _hasOwnProp.call(obj, prop));

packages/react-native/Libraries/Animated/nodes/AnimatedStyle.js

@@ -255,4 +255,6 @@ export default class AnimatedStyle extends AnimatedWithChildren {
 const _hasOwnProp = Object.prototype.hasOwnProperty;
 const hasOwn: (obj: Readonly<{...}>, prop: string) => boolean =
   // $FlowFixMe[method-unbinding]
+  /* $FlowFixMe[invalid-this-arg] Error exposed after fixing this typing
+   * unsoundness in flow */
   Object.hasOwn ?? ((obj, prop) => _hasOwnProp.call(obj, prop));

packages/react-native/Libraries/Components/ScrollView/ScrollView.js

@@ -1069,6 +1069,8 @@ class ScrollView extends React.Component<ScrollViewProps, ScrollViewState> {
           nodeHandle,
           nullthrows(findNodeHandle<$FlowFixMe>(this)),
           // $FlowFixMe[method-unbinding] added when improving typing for this parameters
+          /* $FlowFixMe[incompatible-type] Error exposed after fixing this
+           * typing unsoundness in flow */
           this._textInputFocusError,
           this._inputMeasureAndScrollToKeyboard,
         );
@@ -1077,6 +1079,8 @@ class ScrollView extends React.Component<ScrollViewProps, ScrollViewState> {
           this._innerView.nativeInstance,
           this._inputMeasureAndScrollToKeyboard,
           // $FlowFixMe[method-unbinding] added when improving typing for this parameters
+          /* $FlowFixMe[incompatible-type] Error exposed after fixing this
+           * typing unsoundness in flow */
           this._textInputFocusError,
         );
       }

packages/react-native/Libraries/Modal/Modal.js

@@ -339,6 +339,8 @@ class Modal extends React.Component<ModalProps, ModalState> {
         identifier={this._identifier}
         style={styles.modal}
         // $FlowFixMe[method-unbinding] added when improving typing for this parameters
+        /* $FlowFixMe[incompatible-type] Error exposed after fixing this typing
+         * unsoundness in flow */
         onStartShouldSetResponder={this._shouldSetResponder}
         supportedOrientations={this.props.supportedOrientations}
         onOrientationChange={this.props.onOrientationChange}

packages/react-native/Libraries/Utilities/deepFreezeAndThrowOnMutationInDev.js

@@ -49,6 +49,8 @@ function deepFreezeAndThrowOnMutationInDev<T extends {...} | Array<unknown>>(
 
     for (let i = 0; i < keys.length; i++) {
       const key = keys[i];
+      /* $FlowFixMe[invalid-this-arg] Error exposed after fixing this typing
+       * unsoundness in flow */
       if (hasOwnProperty.call(object, key)) {
         Object.defineProperty(object, key, {
           get: identity.bind(null, object[key]),
@@ -64,6 +66,8 @@ function deepFreezeAndThrowOnMutationInDev<T extends {...} | Array<unknown>>(
 
     for (let i = 0; i < keys.length; i++) {
       const key = keys[i];
+      /* $FlowFixMe[invalid-this-arg] Error exposed after fixing this typing
+       * unsoundness in flow */
       if (hasOwnProperty.call(object, key)) {
         deepFreezeAndThrowOnMutationInDev(object[key]);
       }

packages/react-native/Libraries/promiseRejectionTrackingOptions.js

@@ -28,9 +28,13 @@ const rejectionTrackingOptions: NonNullable<Parameters<enable>[0]> = {
       message = '';
     } else if (
       // $FlowFixMe[method-unbinding] added when improving typing for this parameters
+      /* $FlowFixMe[invalid-this-arg] Error exposed after fixing this typing
+       * unsoundness in flow */
       Object.prototype.toString.call(rejection) === '[object Error]'
     ) {
       // $FlowFixMe[method-unbinding] added when improving typing for this parameters
+      /* $FlowFixMe[invalid-this-arg] Error exposed after fixing this typing
+       * unsoundness in flow */
       message = Error.prototype.toString.call(rejection);
     } else {
       try {

packages/react-native/src/private/animated/createAnimatedPropsMemoHook.js

@@ -357,4 +357,6 @@ function areCompositeKeyComponentsEqual(
 const _hasOwnProp = Object.prototype.hasOwnProperty;
 const hasOwn: (obj: Readonly<{...}>, prop: string) => boolean =
   // $FlowFixMe[method-unbinding]
+  /* $FlowFixMe[invalid-this-arg] Error exposed after fixing this typing
+   * unsoundness in flow */
   Object.hasOwn ?? ((obj, prop) => _hasOwnProp.call(obj, prop));

packages/react-native/src/private/devsupport/devmenu/elementinspector/XHRInterceptor.js

@@ -122,6 +122,8 @@ const XHRInterceptor = {
       if (openCallback) {
         openCallback(method, url, this);
       }
+      /* $FlowFixMe[invalid-this-arg] Error exposed after fixing this typing
+       * unsoundness in flow */
       originalXHROpen.apply(this, arguments);
     };
 
@@ -136,6 +138,8 @@ const XHRInterceptor = {
       if (requestHeaderCallback) {
         requestHeaderCallback(header, value, this);
       }
+      /* $FlowFixMe[invalid-this-arg] Error exposed after fixing this typing
+       * unsoundness in flow */
       originalXHRSetRequestHeader.apply(this, arguments);
     };
 
@@ -190,6 +194,8 @@ const XHRInterceptor = {
           false,
         );
       }
+      /* $FlowFixMe[invalid-this-arg] Error exposed after fixing this typing
+       * unsoundness in flow */
       originalXHRSend.apply(this, arguments);
     };
     isInterceptorEnabled = true;