Skip to content

Commit d44efb0

Browse files
j-piaseckimeta-codesync[bot]
authored andcommitted
Cover react/renderer/imagemanager with Stable API guards (#58307)
Summary: Pull Request resolved: #58307 Classifies `react/renderer/imagemanager:imagemanager` as a "for frameworks" target under the three-tier C++ stable API visibility model. Consumers that opt into `RN_STRICT_API` now get a warning if they include its headers directly, which they can acknowledge with `RN_ALLOW_FRAMEWORKS`; without that flag the guards are inert, so no existing build changes behaviour. `React-Fabric` already depended on `React-cxxstableapi` from an earlier migration in the same pod, so the module's subspec needs no change. Changelog: [Internal] Reviewed By: rubennorte Differential Revision: D118621752 fbshipit-source-id: ecf701cc3377904088a7bd56bf39b2b924850ca2
1 parent 38fd9d5 commit d44efb0

18 files changed

Lines changed: 40 additions & 2 deletions

File tree

packages/react-native/ReactCommon/react/renderer/imagemanager/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ react_native_android_selector(reactnativejni reactnativejni "")
3636
target_link_libraries(react_renderer_imagemanager
3737
folly_runtime
3838
${mapbufferjni}
39+
react_cxxstableapi
3940
react_debug
4041
react_renderer_core
4142
react_renderer_debug

packages/react-native/ReactCommon/react/renderer/imagemanager/ImageManager.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/FrameworksGuard.h>
11+
1012
#include <memory>
1113

1214
#include <react/renderer/core/ReactPrimitives.h>

packages/react-native/ReactCommon/react/renderer/imagemanager/ImageRequest.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/FrameworksGuard.h>
11+
1012
#include <react/renderer/imagemanager/ImageResponse.h>
1113
#include <react/renderer/imagemanager/ImageResponseObserver.h>
1214
#include <react/renderer/imagemanager/ImageResponseObserverCoordinator.h>

packages/react-native/ReactCommon/react/renderer/imagemanager/ImageResponse.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/FrameworksGuard.h>
11+
1012
#include <memory>
1113

1214
namespace facebook::react {

packages/react-native/ReactCommon/react/renderer/imagemanager/ImageResponseObserver.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/FrameworksGuard.h>
11+
1012
#include <react/renderer/imagemanager/ImageResponse.h>
1113

1214
namespace facebook::react {

packages/react-native/ReactCommon/react/renderer/imagemanager/ImageResponseObserverCoordinator.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/FrameworksGuard.h>
11+
1012
#include <react/renderer/imagemanager/ImageResponse.h>
1113
#include <react/renderer/imagemanager/ImageResponseObserver.h>
1214
#include <react/utils/SharedFunction.h>

packages/react-native/ReactCommon/react/renderer/imagemanager/ImageTelemetry.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/FrameworksGuard.h>
11+
1012
#include <react/renderer/core/ReactPrimitives.h>
1113
#include <react/utils/Telemetry.h>
1214

packages/react-native/ReactCommon/react/renderer/imagemanager/platform/android/react/renderer/imagemanager/ImageFetcher.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/FrameworksGuard.h>
11+
1012
#include <react/renderer/imagemanager/ImageRequest.h>
1113
#include <react/renderer/imagemanager/ImageRequestParams.h>
1214
#include <react/utils/ContextContainer.h>

packages/react-native/ReactCommon/react/renderer/imagemanager/platform/android/react/renderer/imagemanager/ImageRequestParams.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/FrameworksGuard.h>
11+
1012
#include <utility>
1113

1214
#include <react/renderer/graphics/Color.h>

packages/react-native/ReactCommon/react/renderer/imagemanager/platform/android/react/renderer/imagemanager/conversions.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/FrameworksGuard.h>
11+
1012
#include <react/featureflags/ReactNativeFeatureFlags.h>
1113
#include <react/renderer/core/graphicsConversions.h>
1214
#include <react/renderer/imagemanager/ImageRequestParams.h>

0 commit comments

Comments
 (0)