Repository navigation
Commit c4356db
Invalidate the layer when borderCurve changes on iOS (#59114)
Summary:
On iOS, `RCTViewComponentView updateProps:oldProps:` only invalidates the layer when `borderStyles`, `borderRadii` or `borderColors` change. A change to `borderCurve` alone is parsed into `borderCurves` but never reaches `layer.cornerCurve`, so the old curve stays on screen until some other border prop changes. This adds `borderCurves` to that comparison.
## Changelog:
[IOS] [FIXED] - Apply `borderCurve` changes that are not accompanied by another border prop change
Pull Request resolved: #59114
Test Plan: On the iOS simulator (0.88.0-rc.4 with React Native built from source), a plain `View` with `borderRadius: 80` and `backgroundColor: 'blue'`, layered over a static `borderCurve: 'circular'` box, toggles `borderCurve` between `circular` and `continuous` with `setState` every 1.5s. Before the change the shape never changes, after it the `continuous` frames show the `circular` box outlining the corners.
Reviewed By: cipolleschi
Differential Revision: D126055226
Pulled By: javache
fbshipit-source-id: b7ba0762f2912a635a3152a130336dd4ea3c26ee1 parent 5342803 commit c4356db
1 file changed
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
461 | 461 | | |
462 | 462 | | |
463 | 463 | | |
464 | | - | |
| 464 | + | |
| 465 | + | |
465 | 466 | | |
466 | 467 | | |
467 | 468 | | |
| |||
0 commit comments