Make animationbackend implementation headers private (#58858)

Summary:
Pull Request resolved: #58858

`AnimatedPropsSerializer.h`, `AnimatedPropsRegistry.h` and `AnimationBackendCommitHook.h` are implementation details of `AnimationBackend` with no users outside React Native, so lower them from "for frameworks" to private.

`AnimationBackend.h` (for frameworks) previously included the registry and commit hook headers, which would leak private headers to its consumers, so we decouple them:
- forward-declare `AnimatedPropsRegistry`, `AnimationBackendCommitHook` and `SurfaceUpdates`;
- hold the commit hook through `std::unique_ptr` and define the destructor out of line;
- make `commitUpdates` private; it is only called from within `AnimationBackend`.

Changelog: [Internal]

Reviewed By: christophpurrer

Differential Revision: D123418519

Author: coado

packages/react-native/ReactCommon/react/renderer/animationbackend/AnimatedPropsRegistry.h

@@ -7,7 +7,7 @@
 
 #pragma once
 
-#include <react/cxxstableapi/FrameworksGuard.h>
+#include <react/cxxstableapi/PrivateGuard.h>
 
 #include <React/RendererCore.h>
 #include <React/View.h>

packages/react-native/ReactCommon/react/renderer/animationbackend/AnimatedPropsSerializer.h

@@ -7,7 +7,7 @@
 
 #pragma once
 
-#include <react/cxxstableapi/FrameworksGuard.h>
+#include <react/cxxstableapi/PrivateGuard.h>
 
 #include <folly/dynamic.h>
 #include "AnimatedProps.h"

packages/react-native/ReactCommon/react/renderer/animationbackend/AnimationBackend.cpp

@@ -7,6 +7,7 @@
 
 #include "AnimationBackend.h"
 #include "AnimatedPropsRegistry.h"
+#include "AnimationBackendCommitHook.h"
 
 #include <react/debug/react_native_assert.h>
 #include <react/featureflags/ReactNativeFeatureFlags.h>
@@ -53,7 +54,10 @@ AnimationBackend::AnimationBackend(
     std::shared_ptr<UIManager> uiManager)
     : animatedPropsRegistry_(std::make_shared<AnimatedPropsRegistry>()),
       animationChoreographer_(std::move(animationChoreographer)),
-      commitHook_(*uiManager, animatedPropsRegistry_),
+      commitHook_(
+          std::make_unique<AnimationBackendCommitHook>(
+              *uiManager,
+              animatedPropsRegistry_)),
       uiManager_(std::move(uiManager)) {
   react_native_assert(uiManager_.expired() == false);
 
@@ -75,6 +79,8 @@ AnimationBackend::AnimationBackend(
   }
 }
 
+AnimationBackend::~AnimationBackend() = default;
+
 void AnimationBackend::unpackMutations(
     AnimationMutations& mutations,
     std::unordered_map<SurfaceId, SurfaceUpdates>& surfaceUpdates,

packages/react-native/ReactCommon/react/renderer/animationbackend/AnimationBackend.h

@@ -15,16 +15,19 @@
 #include <react/renderer/uimanager/UIManagerAnimationBackend.h>
 #include <functional>
 #include <memory>
+#include <mutex>
 #include <set>
+#include <unordered_map>
 #include <vector>
 #include "AnimatedProps.h"
-#include "AnimatedPropsRegistry.h"
-#include "AnimationBackendCommitHook.h"
 #include "AnimationChoreographer.h"
 
 namespace facebook::react {
 
 class AnimationBackend;
+class AnimationBackendCommitHook;
+class AnimatedPropsRegistry;
+struct SurfaceUpdates;
 
 struct AnimationMutation {
   Tag tag;
@@ -53,7 +56,7 @@ class AnimationBackend : public UIManagerAnimationBackend {
   AnimationBackend(
       std::shared_ptr<AnimationChoreographer> animationChoreographer,
       std::shared_ptr<UIManager> uiManager);
-  void commitUpdates(SurfaceId surfaceId, SurfaceUpdates &surfaceUpdates);
+  ~AnimationBackend() override;
   void synchronouslyUpdateProps(const std::unordered_map<Tag, AnimatedProps> &updates);
   void requestAsyncFlushForSurfaces(const std::set<SurfaceId> &surfaces);
   void clearRegistry(SurfaceId surfaceId) override;
@@ -67,6 +70,7 @@ class AnimationBackend : public UIManagerAnimationBackend {
   void stop(CallbackId callbackId) override;
 
  private:
+  void commitUpdates(SurfaceId surfaceId, SurfaceUpdates &surfaceUpdates);
   void unpackMutations(
       AnimationMutations &mutations,
       std::unordered_map<SurfaceId, SurfaceUpdates> &surfaceUpdates,
@@ -78,7 +82,7 @@ class AnimationBackend : public UIManagerAnimationBackend {
   std::vector<CallbackWithId> callbacks;
   std::shared_ptr<AnimatedPropsRegistry> animatedPropsRegistry_;
   std::shared_ptr<AnimationChoreographer> animationChoreographer_;
-  AnimationBackendCommitHook commitHook_;
+  std::unique_ptr<AnimationBackendCommitHook> commitHook_;
   std::weak_ptr<UIManager> uiManager_;
   std::shared_ptr<CallInvoker> jsInvoker_;
   bool isRenderCallbackStarted_{false};

packages/react-native/ReactCommon/react/renderer/animationbackend/AnimationBackendCommitHook.h

@@ -7,7 +7,7 @@
 
 #pragma once
 
-#include <react/cxxstableapi/FrameworksGuard.h>
+#include <react/cxxstableapi/PrivateGuard.h>
 
 #include <React/RendererCore.h>
 #include <react/renderer/uimanager/UIManager.h>

scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api

@@ -1568,9 +1568,9 @@ class facebook::react::AnimationBackend : public facebook::react::UIManagerAnima
   public virtual void registerJSInvoker(std::shared_ptr<facebook::react::CallInvoker> jsInvoker) override;
   public virtual void stop(facebook::react::CallbackId callbackId) override;
   public virtual void trigger() override;
-  public void commitUpdates(facebook::react::SurfaceId surfaceId, facebook::react::SurfaceUpdates& surfaceUpdates);
   public void requestAsyncFlushForSurfaces(const std::set<facebook::react::SurfaceId>& surfaces);
   public void synchronouslyUpdateProps(const std::unordered_map<facebook::react::Tag, facebook::react::AnimatedProps>& updates);
+  public ~AnimationBackend() override;
 }
 
 class facebook::react::AnimationBackendCommitHook : public facebook::react::UIManagerCommitHook {

scripts/cxx-api/api-snapshots/ReactAndroidNewarchCxx.api

@@ -1563,9 +1563,9 @@ class facebook::react::AnimationBackend : public facebook::react::UIManagerAnima
   public virtual void registerJSInvoker(std::shared_ptr<facebook::react::CallInvoker> jsInvoker) override;
   public virtual void stop(facebook::react::CallbackId callbackId) override;
   public virtual void trigger() override;
-  public void commitUpdates(facebook::react::SurfaceId surfaceId, facebook::react::SurfaceUpdates& surfaceUpdates);
   public void requestAsyncFlushForSurfaces(const std::set<facebook::react::SurfaceId>& surfaces);
   public void synchronouslyUpdateProps(const std::unordered_map<facebook::react::Tag, facebook::react::AnimatedProps>& updates);
+  public ~AnimationBackend() override;
 }
 
 class facebook::react::AnimationBackendCommitHook : public facebook::react::UIManagerCommitHook {

scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api

@@ -1567,9 +1567,9 @@ class facebook::react::AnimationBackend : public facebook::react::UIManagerAnima
   public virtual void registerJSInvoker(std::shared_ptr<facebook::react::CallInvoker> jsInvoker) override;
   public virtual void stop(facebook::react::CallbackId callbackId) override;
   public virtual void trigger() override;
-  public void commitUpdates(facebook::react::SurfaceId surfaceId, facebook::react::SurfaceUpdates& surfaceUpdates);
   public void requestAsyncFlushForSurfaces(const std::set<facebook::react::SurfaceId>& surfaces);
   public void synchronouslyUpdateProps(const std::unordered_map<facebook::react::Tag, facebook::react::AnimatedProps>& updates);
+  public ~AnimationBackend() override;
 }
 
 class facebook::react::AnimationBackendCommitHook : public facebook::react::UIManagerCommitHook {

scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api

@@ -4118,9 +4118,9 @@ class facebook::react::AnimationBackend : public facebook::react::UIManagerAnima
   public virtual void registerJSInvoker(std::shared_ptr<facebook::react::CallInvoker> jsInvoker) override;
   public virtual void stop(facebook::react::CallbackId callbackId) override;
   public virtual void trigger() override;
-  public void commitUpdates(facebook::react::SurfaceId surfaceId, facebook::react::SurfaceUpdates& surfaceUpdates);
   public void requestAsyncFlushForSurfaces(const std::set<facebook::react::SurfaceId>& surfaces);
   public void synchronouslyUpdateProps(const std::unordered_map<facebook::react::Tag, facebook::react::AnimatedProps>& updates);
+  public ~AnimationBackend() override;
 }
 
 class facebook::react::AnimationBackendCommitHook : public facebook::react::UIManagerCommitHook {

scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api

@@ -4106,9 +4106,9 @@ class facebook::react::AnimationBackend : public facebook::react::UIManagerAnima
   public virtual void registerJSInvoker(std::shared_ptr<facebook::react::CallInvoker> jsInvoker) override;
   public virtual void stop(facebook::react::CallbackId callbackId) override;
   public virtual void trigger() override;
-  public void commitUpdates(facebook::react::SurfaceId surfaceId, facebook::react::SurfaceUpdates& surfaceUpdates);
   public void requestAsyncFlushForSurfaces(const std::set<facebook::react::SurfaceId>& surfaces);
   public void synchronouslyUpdateProps(const std::unordered_map<facebook::react::Tag, facebook::react::AnimatedProps>& updates);
+  public ~AnimationBackend() override;
 }
 
 class facebook::react::AnimationBackendCommitHook : public facebook::react::UIManagerCommitHook {