lint: Fix lint errors

Author: tjtanjin

src/controllers/__tests__/geminiQuery.test.ts

@@ -4,7 +4,7 @@ import { Request, Response } from 'express';
 import * as configModule from '../../config';
 import { generateText } from '../../services/llmWrapper';
 import { initializedRagService } from '../../services/ragService';
-import { GeminiChatCompletionResponse, GeminiStreamChunk } from '../../types';
+import { GeminiChatCompletionResponse } from '../../types';
 import { handleGeminiBatch, handleGeminiStream } from '../geminiQuery';
 
 // Mock src/config
@@ -19,12 +19,12 @@ jest.mock('../../config', () => ({
 
     chromaPort: '8000',
 
+    chromaUrl: 'http://localhost',
+
     geminiApiKey: 'test-api-key',
 
     geminiChatModel: 'gemini-pro',
 
-    chromaUrl: 'http://localhost',
-
     // Default mock, can be overridden per test
     geminiEmbeddingModel: 'text-embedding-004',
     // Default for most tests
@@ -291,10 +291,10 @@ describe('Gemini RAG Query Controllers', () => {
       const res = mockResponse() as Response;
       mockRagService.queryChunks.mockResolvedValue([]); // No RAG context
 
-      const streamChunk1: GeminiStreamChunk = {
+      const streamChunk1 = {
         candidates: [{ content: { parts: [{ text: 'Stream chunk 1' }], role: 'model' }, index: 0 }],
       };
-      const streamChunk2: GeminiStreamChunk = {
+      const streamChunk2 = {
         candidates: [{ content: { parts: [{ text: 'Stream chunk 2' }], role: 'model' }, index: 0 }],
       };
 

src/controllers/geminiQuery.ts

@@ -3,7 +3,7 @@ import { Request, Response } from 'express';
 import { config } from '../config';
 import { generateText } from '../services/llmWrapper';
 import { initializedRagService } from '../services/ragService';
-import { GeminiQueryRequest, LLMChatResponse, LLMStreamChunk } from '../types';
+import { GeminiQueryRequest, LLMChatResponse } from '../types';
 
 export const handleGeminiBatch = async (req: Request, res: Response) => {
   const model = req.params.model;

src/index.ts

@@ -18,6 +18,7 @@ const allowedOrigins = process.env.FRONTEND_WEBSITE_URLS?.split(',').map((origin
 // handle cors with a dynamic origin function
 app.use(
   cors({
+    credentials: true,
     origin: (origin, callback) => {
       // allow requests with no origin (like mobile apps, curl requests)
       if (!origin) return callback(null, true);
@@ -31,7 +32,6 @@ app.use(
         return callback(new Error(`Not allowed by CORS: ${origin}`));
       }
     },
-    credentials: true,
   })
 );
 app.use(`${API_PREFIX}/rag/manage`, ragManagementRouter);

src/routers/geminiQuery.ts

@@ -6,20 +6,20 @@ import { queryApiKeyAuth } from '../middleware/auth';
 const geminiRouter = Router();
 
 // gemini proxy endpoints
-geminiRouter.post('/gemini/models/:model', (req, res) => {
-	const model = req.params.model;
+geminiRouter.post('/gemini/models/:model', queryApiKeyAuth, (req, res) => {
+  const model = req.params.model;
 
-	if (model.endsWith(':generateContent')) {
-		req.params.model = model.replace(':generateContent', '');
-		return handleGeminiBatch(req, res);
-	}
+  if (model.endsWith(':generateContent')) {
+    req.params.model = model.replace(':generateContent', '');
+    return handleGeminiBatch(req, res);
+  }
 
-	if (model.endsWith(':streamGenerateContent')) {
-		req.params.model = model.replace(':streamGenerateContent', '');
-		return handleGeminiStream(req, res);
-	}
+  if (model.endsWith(':streamGenerateContent')) {
+    req.params.model = model.replace(':streamGenerateContent', '');
+    return handleGeminiStream(req, res);
+  }
 
-	return res.status(404).json({ error: 'Unsupported Gemini operation' });
+  return res.status(404).json({ error: 'Unsupported Gemini operation' });
 });
 
 export { geminiRouter };

src/services/__tests__/llmWrapper.test.ts

@@ -1,12 +1,10 @@
 import { config } from '../../config';
 import {
-  // LLMStreamChunk is GeminiStreamChunk, already imported
   GeminiBatchEmbeddingsRequest,
   GeminiBatchEmbeddingsResponse,
   GeminiChatCompletionResponse,
   GeminiContent,
   GeminiEmbedding,
-  GeminiStreamChunk,
   LLMChatResponse,
   LLMEmbeddingsResponse,
 } from '../../types';
@@ -64,7 +62,7 @@ describe('LLM Wrapper Service (Gemini-only)', () => {
 
     it('should call streamGenerateContent and trigger onChunk for streaming requests', async () => {
       const mockOnChunk = jest.fn();
-      const mockChunk: GeminiStreamChunk = {
+      const mockChunk = {
         candidates: [{ content: { parts: [{ text: 'Hello' }], role: 'model' }, index: 0 }], // Added index
       };
 

src/services/gemini.ts

@@ -5,7 +5,6 @@ import {
   GeminiChatCompletionResponse,
   GeminiChatModel,
   GeminiContent,
-  GeminiStreamChunk,
 } from '../types';
 
 const GEMINI_API_BASE_URL = 'https://generativelanguage.googleapis.com/v1beta';

src/services/llmWrapper.ts

@@ -4,12 +4,10 @@ import {
   GeminiChatModel as GeminiModelName,
   GeminiContent,
   GeminiEmbeddingModel,
-  GeminiStreamChunk,
   LLMChatRequestOptions,
   LLMChatResponse,
   LLMEmbeddingsRequestOptions,
   LLMEmbeddingsResponse,
-  LLMStreamChunk,
 } from '../types';
 import {
   batchEmbedContents as batchGeminiEmbeddings,

src/types/gemini.ts

@@ -79,9 +79,6 @@ export type GeminiChatPayload = {
   // `model` is part of the URL for Gemini, not typically in the payload body for generateContent.
 };
 
-// This will be GeminiChatCompletionResponse itself, as Gemini streams full response objects.
-export type GeminiStreamChunk = GeminiChatCompletionResponse;
-
 export type GeminiQueryRequest = {
   contents: GeminiContent[];
 };

src/types/llmWrapper.ts

@@ -21,5 +21,3 @@ export type LLMEmbeddingsRequestOptions = {
 export type LLMChatResponse = Gemini.GeminiChatCompletionResponse;
 
 export type LLMEmbeddingsResponse = Gemini.GeminiBatchEmbeddingsResponse;
-
-export type LLMStreamChunk = Gemini.GeminiStreamChunk;