Skip to content

Commit 9d46f7e

Browse files
committed
fix: restore task detail view clicking (regression fix)
Remove navigation_view.pop() from the selected_task reaction, replacing it with a direct unparent(). The pop() was triggering the connect_popped handler which cleared selected_task before the new detail page could be pushed, making task clicks appear to do nothing.
1 parent 8fe2c0f commit 9d46f7e

1 file changed

Lines changed: 4 additions & 5 deletions

File tree

src/dialogs/task_manager_dialog.rs

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -126,14 +126,13 @@ mod imp {
126126
if let Some(task) = task {
127127
this.build_task_view(&task);
128128
// If selected_task_view already has a parent from a previous detail page,
129-
// pop the old page and unparent the view to avoid GTK assertion:
129+
// unparent it directly to avoid GTK assertion:
130130
// 'gtk_widget_get_parent (child) == NULL'
131+
// NOTE: Do NOT call navigation_view.pop() here — it triggers connect_popped
132+
// which clears selected_task and breaks the flow.
131133
let stv = &this.imp().selected_task_view;
132134
if stv.parent().is_some() {
133-
this.imp().navigation_view.pop();
134-
if stv.parent().is_some() {
135-
stv.unparent();
136-
}
135+
stv.unparent();
137136
}
138137
this.imp().navigation_view.push(&adw::NavigationPage::new(
139138
stv,

0 commit comments

Comments
 (0)