diff --git a/news/changelog-1.11.md b/news/changelog-1.11.md index 02588996bb3..57eb1f4d8e7 100644 --- a/news/changelog-1.11.md +++ b/news/changelog-1.11.md @@ -4,6 +4,10 @@ All changes included in 1.11: - ([#14741](https://github.com/quarto-dev/quarto-cli/issues/14741)): Don't wrap the `longtable` environment of a cross-referenceable table in a `{ ... }` group. Pandoc emits that group to scope its `\def\LTcaptype{none}`, which Quarto removes when adding its own `\caption`; keeping the now-pointless group broke packages that move the environment out of the text flow, such as `endfloat` with `\DeclareDelayedFloatFlavor*{longtable}{table}`. +## Accessibility + +- ([#14615](https://github.com/quarto-dev/quarto-cli/issues/14615)): Fix invalid `role="menu"` on the website navbar's collapse toggle button, flagged by axe-core (`aria-allowed-role`) and WAVE (`aria_menu_broken`) when the navbar collapses to the hamburger at narrow viewports. + ## Engines ### `knitr` diff --git a/src/resources/projects/website/templates/navtoggle.ejs b/src/resources/projects/website/templates/navtoggle.ejs index 2692783929a..0b4393abf87 100644 --- a/src/resources/projects/website/templates/navtoggle.ejs +++ b/src/resources/projects/website/templates/navtoggle.ejs @@ -1,5 +1,5 @@ \ No newline at end of file diff --git a/tests/docs/smoke-all/website/navbar-toggler-role/.gitignore b/tests/docs/smoke-all/website/navbar-toggler-role/.gitignore new file mode 100644 index 00000000000..91e4dc52c80 --- /dev/null +++ b/tests/docs/smoke-all/website/navbar-toggler-role/.gitignore @@ -0,0 +1,3 @@ +/.quarto/ +/_site/ +**/*.quarto_ipynb diff --git a/tests/docs/smoke-all/website/navbar-toggler-role/_quarto.yml b/tests/docs/smoke-all/website/navbar-toggler-role/_quarto.yml new file mode 100644 index 00000000000..ac126604ab7 --- /dev/null +++ b/tests/docs/smoke-all/website/navbar-toggler-role/_quarto.yml @@ -0,0 +1,11 @@ +project: + type: website + +website: + title: "navbar-toggler-role" + navbar: + right: + - text: Home + href: index.qmd + - text: About + href: index.qmd diff --git a/tests/docs/smoke-all/website/navbar-toggler-role/index.qmd b/tests/docs/smoke-all/website/navbar-toggler-role/index.qmd new file mode 100644 index 00000000000..333663b36aa --- /dev/null +++ b/tests/docs/smoke-all/website/navbar-toggler-role/index.qmd @@ -0,0 +1,15 @@ +--- +title: "Home" +_quarto: + tests: + html: + ensureHtmlElements: + - + - 'button.navbar-toggler[aria-expanded][aria-controls][aria-label]' + - + - 'button.navbar-toggler[role]' +--- + +The navbar's collapse toggle button must keep its native button semantics: +no `role` override (`role="menu"` is invalid on a button — #14615), with +`aria-expanded`, `aria-controls`, and `aria-label` intact.