Skip to content

Commit fca5a12

Browse files
authored
Fix #929 by updating Eigen to version 3.4.1 (#934)
The warning described in #929 seems to be the result of using an older version of Eigen. Updating the version makes the warning go go away.
1 parent 1269131 commit fca5a12

2 files changed

Lines changed: 8 additions & 7 deletions

File tree

Makefile

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414

15-
# Version info for the copy of Eigen we will download and build locally.
16-
EIGEN_PREFIX = "3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e"
15+
# If this is changed, updated the value in ./WORKSPACE too.
16+
EIGEN_COMMIT = "b66188b5dfd147265bfa9ec47595ca0db72d21f5"
1717
EIGEN_URL = "https://gitlab.com/libeigen/eigen/-/archive/"
1818

1919
# Default build targets. Additional may be added conditionally below.
@@ -197,9 +197,9 @@ check-cuquantum-root-set:
197197

198198
eigen:
199199
-rm -rf eigen
200-
wget $(EIGEN_URL)/$(EIGEN_PREFIX)/eigen-$(EIGEN_PREFIX).tar.gz
201-
tar -xzf eigen-$(EIGEN_PREFIX).tar.gz && mv eigen-$(EIGEN_PREFIX) eigen
202-
rm eigen-$(EIGEN_PREFIX).tar.gz
200+
wget $(EIGEN_URL)/$(EIGEN_COMMIT)/eigen-$(EIGEN_COMMIT).tar.gz
201+
tar -xzf eigen-$(EIGEN_COMMIT).tar.gz && mv eigen-$(EIGEN_COMMIT) eigen
202+
rm eigen-$(EIGEN_COMMIT).tar.gz
203203

204204
.PHONY: clean
205205
clean:

WORKSPACE

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,10 @@ load("@org_tensorflow//tensorflow:workspace0.bzl", "tf_workspace0")
5555

5656
tf_workspace0()
5757

58-
EIGEN_COMMIT = "d71c30c47858effcbd39967097a2d99ee48db464" # 3.4.1
58+
# https://gitlab.com/libeigen/eigen/-/releases/3.4.1
59+
EIGEN_COMMIT = "b66188b5dfd147265bfa9ec47595ca0db72d21f5"
5960

60-
EIGEN_SHA256 = "f1d28c2205d015490a685b1e5a171c434da87f757746724de3cb85e69621dec2"
61+
EIGEN_SHA256 = "2c167ff09e88a5261111bc2aa7f18ae2e78d73fd42339387532937b0c2629829"
6162

6263
http_archive(
6364
name = "eigen",

0 commit comments

Comments
 (0)