Skip to content

Commit c039cc1

Browse files
committed
Simplify the platform-specific definitions
It seems that `--cxxopt=-D_GLIBCXX_USE_CXX11_ABI=1` works on all platforms (possibly because the Windows compiler ignores altogether?). We may as well pull that out into a single build setting that's common for all platforms.
1 parent b92e4d8 commit c039cc1

1 file changed

Lines changed: 3 additions & 6 deletions

File tree

.bazelrc

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,19 +24,16 @@ common --verbose_failures
2424
common --enable_platform_specific_config
2525

2626
build:linux --copt=-std=c++17
27-
build:linux --copt=-D_GLIBCXX_USE_CXX11_ABI=1
2827
build:linux --cxxopt=-std=c++17
29-
build:linux --cxxopt=-D_GLIBCXX_USE_CXX11_ABI=1
3028

3129
build:macos --copt=-std=c++17
32-
build:macos --copt=-D_GLIBCXX_USE_CXX11_ABI=1
3330
build:macos --cxxopt=-std=c++17
34-
build:macos --cxxopt=-D_GLIBCXX_USE_CXX11_ABI=1
3531

3632
build:windows --copt=/std:c++17
37-
build:windows --copt=-D_GLIBCXX_USE_CXX11_ABI=1
3833
build:windows --cxxopt=/std:c++17
39-
build:windows --cxxopt=-D_GLIBCXX_USE_CXX11_ABI=1
34+
35+
build --copt=-D_GLIBCXX_USE_CXX11_ABI=1
36+
build --cxxopt=-D_GLIBCXX_USE_CXX11_ABI=1
4037

4138
# Test flags
4239
test --test_output=errors

0 commit comments

Comments
 (0)