Skip to content

Commit 0647d00

Browse files
authored
Address lint & format warnings from buildifier in WORKSPACE and BUILD files (#948)
No code changes or functional changes. This fixes all warnings generated by running ```shell buildifier -mode=warn -lint=warn filename ```
1 parent 3b2140d commit 0647d00

4 files changed

Lines changed: 186 additions & 179 deletions

File tree

WORKSPACE

Lines changed: 14 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -39,26 +39,25 @@ http_archive(
3939
url = "https://github.com/tensorflow/tensorflow/archive/refs/tags/v2.13.0.zip",
4040
)
4141

42-
load("@org_tensorflow//tensorflow:workspace3.bzl", "workspace")
42+
load("@org_tensorflow//tensorflow:workspace3.bzl", "tf_workspace3")
4343

44-
workspace()
44+
tf_workspace3()
4545

46-
load("@org_tensorflow//tensorflow:workspace2.bzl", "workspace")
46+
load("@org_tensorflow//tensorflow:workspace2.bzl", "tf_workspace2")
4747

48-
workspace()
48+
tf_workspace2()
4949

50-
load("@org_tensorflow//tensorflow:workspace1.bzl", "workspace")
50+
load("@org_tensorflow//tensorflow:workspace1.bzl", "tf_workspace1")
5151

52-
workspace()
52+
tf_workspace1()
5353

54-
load("@org_tensorflow//tensorflow:workspace0.bzl", "workspace")
54+
load("@org_tensorflow//tensorflow:workspace0.bzl", "tf_workspace0")
5555

56-
workspace()
56+
tf_workspace0()
5757

58+
EIGEN_COMMIT = "d71c30c47858effcbd39967097a2d99ee48db464" # 3.4.1
5859

59-
EIGEN_COMMIT = "3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e"
60-
EIGEN_SHA256 = "eca9847b3fe6249e0234a342b78f73feec07d29f534e914ba5f920f3e09383a3"
61-
60+
EIGEN_SHA256 = "f1d28c2205d015490a685b1e5a171c434da87f757746724de3cb85e69621dec2"
6261

6362
http_archive(
6463
name = "eigen",
@@ -70,11 +69,10 @@ cc_library(
7069
)
7170
""",
7271
sha256 = EIGEN_SHA256,
73-
strip_prefix = "eigen-{commit}".format(commit = EIGEN_COMMIT),
74-
urls = [
75-
"https://storage.googleapis.com/mirror.tensorflow.org/gitlab.com/libeigen/eigen/-/archive/{commit}/eigen-{commit}.tar.gz".format(commit = EIGEN_COMMIT),
76-
"https://gitlab.com/libeigen/eigen/-/archive/{commit}/eigen-{commit}.tar.gz".format(commit = EIGEN_COMMIT),
77-
],
72+
strip_prefix = "eigen-{commit}".format(commit = EIGEN_COMMIT),
73+
urls = [
74+
"https://gitlab.com/libeigen/eigen/-/archive/{commit}/eigen-{commit}.tar.gz".format(commit = EIGEN_COMMIT),
75+
],
7876
)
7977

8078
load("//third_party/cuquantum:cuquantum_configure.bzl", "cuquantum_configure")

apps/BUILD

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,15 @@
1414

1515
# TODO: remove reliance on getopt (unistd.h) to allow apps to run on Windows.
1616

17+
load("@rules_cc//cc:defs.bzl", "cc_binary")
18+
1719
cc_binary(
1820
name = "qsim_base",
1921
srcs = ["qsim_base.cc"],
22+
data = ["//circuits:circuit_q24"],
2023
deps = [
2124
"//lib:run_qsim_lib",
2225
],
23-
data = ["//circuits:circuit_q24"],
2426
)
2527

2628
cc_binary(

lib/BUILD

Lines changed: 30 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
# limitations under the License.
1414

1515
load("@local_config_cuda//cuda:build_defs.bzl", "cuda_library")
16+
load("@rules_cc//cc:defs.bzl", "cc_library")
1617

1718
package(default_visibility = ["//visibility:public"])
1819

@@ -26,9 +27,9 @@ cc_library(
2627
"bitstring.h",
2728
"channel.h",
2829
"channels_cirq.h",
30+
"circuit.h",
2931
"circuit_noisy.h",
3032
"circuit_qsim_parser.h",
31-
"circuit.h",
3233
"expect.h",
3334
"formux.h",
3435
"fuser.h",
@@ -39,8 +40,8 @@ cc_library(
3940
"gates_cirq.h",
4041
"gates_qsim.h",
4142
"hybrid.h",
42-
"io_file.h",
4343
"io.h",
44+
"io_file.h",
4445
"matrix.h",
4546
"mps_simulator.h",
4647
"mps_statespace.h",
@@ -55,21 +56,21 @@ cc_library(
5556
"simulator_avx512.h",
5657
"simulator_basic.h",
5758
"simulator_sse.h",
59+
"statespace.h",
5860
"statespace_avx.h",
5961
"statespace_avx512.h",
6062
"statespace_basic.h",
6163
"statespace_sse.h",
62-
"statespace.h",
6364
"umux.h",
65+
"unitary_calculator_avx.h",
66+
"unitary_calculator_avx512.h",
67+
"unitary_calculator_basic.h",
68+
"unitary_calculator_sse.h",
6469
"unitaryspace.h",
6570
"unitaryspace_avx.h",
6671
"unitaryspace_avx512.h",
6772
"unitaryspace_basic.h",
6873
"unitaryspace_sse.h",
69-
"unitary_calculator_avx.h",
70-
"unitary_calculator_avx512.h",
71-
"unitary_calculator_basic.h",
72-
"unitary_calculator_sse.h",
7374
"util.h",
7475
"util_cpu.h",
7576
"vectorspace.h",
@@ -98,9 +99,9 @@ cuda_library(
9899
"bitstring.h",
99100
"channel.h",
100101
"channels_cirq.h",
102+
"circuit.h",
101103
"circuit_noisy.h",
102104
"circuit_qsim_parser.h",
103-
"circuit.h",
104105
"expect.h",
105106
"formux.h",
106107
"fuser.h",
@@ -111,8 +112,8 @@ cuda_library(
111112
"gates_cirq.h",
112113
"gates_qsim.h",
113114
"hybrid.h",
114-
"io_file.h",
115115
"io.h",
116+
"io_file.h",
116117
"matrix.h",
117118
"mps_simulator.h",
118119
"mps_statespace.h",
@@ -127,26 +128,26 @@ cuda_library(
127128
"simulator_avx.h",
128129
"simulator_avx512.h",
129130
"simulator_basic.h",
130-
"simulator_sse.h",
131131
"simulator_cuda.h",
132132
"simulator_cuda_kernels.h",
133+
"simulator_sse.h",
134+
"statespace.h",
133135
"statespace_avx.h",
134136
"statespace_avx512.h",
135137
"statespace_basic.h",
136-
"statespace_sse.h",
137138
"statespace_cuda.h",
138139
"statespace_cuda_kernels.h",
139-
"statespace.h",
140+
"statespace_sse.h",
140141
"umux.h",
142+
"unitary_calculator_avx.h",
143+
"unitary_calculator_avx512.h",
144+
"unitary_calculator_basic.h",
145+
"unitary_calculator_sse.h",
141146
"unitaryspace.h",
142147
"unitaryspace_avx.h",
143148
"unitaryspace_avx512.h",
144149
"unitaryspace_basic.h",
145150
"unitaryspace_sse.h",
146-
"unitary_calculator_avx.h",
147-
"unitary_calculator_avx512.h",
148-
"unitary_calculator_basic.h",
149-
"unitary_calculator_sse.h",
150151
"util.h",
151152
"util_cpu.h",
152153
"util_cuda.h",
@@ -156,7 +157,7 @@ cuda_library(
156157
deps = [
157158
":cuda",
158159
"@local_config_cuda//cuda:cuda_headers",
159-
]
160+
],
160161
)
161162

162163
# Full qsim library, including cuQuantum
@@ -167,9 +168,9 @@ cuda_library(
167168
"bitstring.h",
168169
"channel.h",
169170
"channels_cirq.h",
171+
"circuit.h",
170172
"circuit_noisy.h",
171173
"circuit_qsim_parser.h",
172-
"circuit.h",
173174
"expect.h",
174175
"formux.h",
175176
"fuser.h",
@@ -180,8 +181,8 @@ cuda_library(
180181
"gates_cirq.h",
181182
"gates_qsim.h",
182183
"hybrid.h",
183-
"io_file.h",
184184
"io.h",
185+
"io_file.h",
185186
"matrix.h",
186187
"mps_simulator.h",
187188
"mps_statespace.h",
@@ -196,24 +197,24 @@ cuda_library(
196197
"simulator_avx.h",
197198
"simulator_avx512.h",
198199
"simulator_basic.h",
199-
"simulator_sse.h",
200200
"simulator_custatevec.h",
201+
"simulator_sse.h",
202+
"statespace.h",
201203
"statespace_avx.h",
202204
"statespace_avx512.h",
203205
"statespace_basic.h",
204-
"statespace_sse.h",
205206
"statespace_custatevec.h",
206-
"statespace.h",
207+
"statespace_sse.h",
207208
"umux.h",
209+
"unitary_calculator_avx.h",
210+
"unitary_calculator_avx512.h",
211+
"unitary_calculator_basic.h",
212+
"unitary_calculator_sse.h",
208213
"unitaryspace.h",
209214
"unitaryspace_avx.h",
210215
"unitaryspace_avx512.h",
211216
"unitaryspace_basic.h",
212217
"unitaryspace_sse.h",
213-
"unitary_calculator_avx.h",
214-
"unitary_calculator_avx512.h",
215-
"unitary_calculator_basic.h",
216-
"unitary_calculator_sse.h",
217218
"util.h",
218219
"util_cpu.h",
219220
"util_cuda.h",
@@ -263,13 +264,13 @@ cc_library(
263264
"statespace_basic.h",
264265
"statespace_sse.h",
265266
"umux.h",
267+
"unitary_calculator_avx.h",
268+
"unitary_calculator_basic.h",
269+
"unitary_calculator_sse.h",
266270
"unitaryspace.h",
267271
"unitaryspace_avx.h",
268272
"unitaryspace_basic.h",
269273
"unitaryspace_sse.h",
270-
"unitary_calculator_avx.h",
271-
"unitary_calculator_basic.h",
272-
"unitary_calculator_sse.h",
273274
"util.h",
274275
"util_cpu.h",
275276
"vectorspace.h",

0 commit comments

Comments
 (0)