Skip to content

Commit 3364d76

Browse files
Revert "don't omit 1 in str"
1 parent 5f75bcf commit 3364d76

4 files changed

Lines changed: 11 additions & 8 deletions

File tree

test/cython/test_with_unit.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -541,9 +541,9 @@ def test_hash() -> None:
541541
def test_str() -> None:
542542
assert str(val(2, conv(3, 4, 5, 6), s, m)) == '2 m'
543543
assert str(val(2j, conv(3, 4, 5, 6), s)) == '2j s'
544-
assert str(val(1, units=m, display_units=s)) == '1 s'
545-
assert str(val(1, units=m)) == '1 m'
546-
assert str(val(1, units=h)) == '1 s^3600'
544+
assert str(val(1, units=m, display_units=s)) == 's'
545+
assert str(val(1, units=m)) == 'm'
546+
assert str(val(1, units=h)) == 's^3600'
547547
assert str(val([2, 3, 5], units=h, display_units=m)) == '[2 3 5] m'
548548
assert str(val([2, 3], units=h, display_units=mps)) == '[2 3] m/s'
549549

test/test_unit_database.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ def test_get_unit_with_auto_create_override() -> None:
5151
db_manual = UnitDatabase(auto_create_units=False)
5252

5353
u = db_auto.get_unit('missing')
54-
assert str(u) == '1 missing'
54+
assert str(u) == 'missing'
5555
with pytest.raises(KeyError):
5656
db_manual.get_unit('missing')
5757

@@ -61,9 +61,9 @@ def test_get_unit_with_auto_create_override() -> None:
6161
db_manual.get_unit('gone', auto_create=False)
6262

6363
u = db_auto.get_unit('empty', auto_create=True)
64-
assert str(u) == '1 empty'
64+
assert str(u) == 'empty'
6565
u = db_manual.get_unit('empty', auto_create=True)
66-
assert str(u) == '1 empty'
66+
assert str(u) == 'empty'
6767

6868

6969
def test_add_root_unit() -> None:

test/test_value.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,10 +102,10 @@ def test_repr() -> None:
102102
def test_str() -> None:
103103
from tunits.units import mm, meter, kilometer, rad, cyc
104104

105-
assert str(Value(1, mm)) == '1 mm'
105+
assert str(Value(1, mm)) == 'mm'
106106
assert str(Value(4, mm)) == '4 mm'
107107
assert str(2 * meter * kilometer) == '2 km*m'
108-
assert str(cyc) == '1 cyc'
108+
assert str(cyc) == 'cyc'
109109
assert str(3.25 * cyc**2) == '3.25 cyc^2'
110110
assert str(3.25 * cyc * rad) == '3.25 cyc*rad'
111111
assert str((4 * kilometer) ** 0.5) == '2.0 km^(1/2)'

tunits/core/cython/with_unit.pyx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -481,6 +481,9 @@ cdef class WithUnit:
481481

482482
def __str__(self):
483483
unit_str = str(self.display_units)
484+
if not isinstance(self.value, np.ndarray) \
485+
and self.value == 1 and unit_str != '':
486+
return unit_str
484487
val_str = (repr if isinstance(self.value, float) else str)(self.value)
485488
return (val_str + " " + unit_str).strip()
486489

0 commit comments

Comments
 (0)