Skip to content

Commit c611ade

Browse files
authored
Merge pull request #390 from smuppand/gstreamer
chore(multimedia): fix ShellCheck SC2317 warnings in audio, camera, fastrpc, and video tests
2 parents 8a73568 + 9969c6f commit c611ade

4 files changed

Lines changed: 9 additions & 9 deletions

File tree

  • Runner/suites/Multimedia

Runner/suites/Multimedia/CDSP/fastrpc_test/run.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,7 @@ cd "$test_path" || {
119119
}
120120

121121
# -------------------- Helpers --------------------
122+
# shellcheck disable=SC2317 # Helper kept for optional debug use.
122123
log_debug() { [ "$VERBOSE" -eq 1 ] && log_info "[debug] $*"; }
123124

124125
cmd_to_string() {

Runner/suites/Multimedia/Camera/Libcamera_cam/run.sh

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -284,6 +284,13 @@ else
284284
fi
285285
log_info "Summary file: $OUT_DIR/summary.txt"
286286

287+
# ---------- Artifacts ----------
288+
log_info "Artifacts under: $OUT_DIR/"
289+
for IDX in $INDICES; do
290+
CAM_DIR="${OUT_DIR%/}/cam${IDX}"
291+
log_info " - $CAM_DIR/"
292+
done
293+
287294
# ---------- Final verdict ----------
288295
if [ "$OVERALL_PASS" -eq 1 ] && [ $ANY_RC_NONZERO -eq 0 ]; then
289296
echo "$TESTNAME PASS" > "$RES_FILE"
@@ -294,10 +301,3 @@ else
294301
log_fail "$TESTNAME FAIL"
295302
exit 1
296303
fi
297-
298-
# ---------- Artifacts ----------
299-
log_info "Artifacts under: $OUT_DIR/"
300-
for IDX in $INDICES; do
301-
CAM_DIR="${OUT_DIR%/}/cam${IDX}"
302-
log_info " - $CAM_DIR/"
303-
done

Runner/suites/Multimedia/GSTreamer/Audio/Audio_Playback/run.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,7 @@ if [ -n "$channels" ]; then
9696
channelsUser="1"
9797
fi
9898

99+
# shellcheck disable=SC2317 # Invoked indirectly via trap.
99100
cleanup() {
100101
pkill -x gst-launch-1.0 >/dev/null 2>&1 || true
101102
}

Runner/suites/Multimedia/Video/Video_V4L2_Runner/run.sh

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1386,5 +1386,3 @@ else
13861386
printf '%s\n' "$TESTNAME FAIL" >"$RES_FILE"
13871387
exit 1
13881388
fi
1389-
1390-
exit "$suite_rc"

0 commit comments

Comments
 (0)