Skip to content

Commit 9e87e06

Browse files
committed
shellcheck: fix quoting and dead trailing log in Freq_Scaling
Update Runner/suites/Kernel/DCVS/Freq_Scaling/run.sh to: - quote CPUFREQ_PATH when reading cpufreq sysfs files - remove the unreachable trailing completion log after the final PASS/FAIL exit path This is a mechanical ShellCheck cleanup and does not change the intended DCVS frequency scaling test flow. Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
1 parent b97dad6 commit 9e87e06

1 file changed

Lines changed: 4 additions & 6 deletions

File tree

  • Runner/suites/Kernel/DCVS/Freq_Scaling

Runner/suites/Kernel/DCVS/Freq_Scaling/run.sh

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -64,20 +64,20 @@ if [ "$miss" -eq 1 ]; then
6464
fi
6565

6666
log_info "Reading scaling governor..."
67-
GOVERNOR=$(cat $CPUFREQ_PATH/scaling_governor)
67+
GOVERNOR=$(cat "$CPUFREQ_PATH"/scaling_governor)
6868
log_info "Current governor: $GOVERNOR"
6969

7070
log_info "Reading min/max frequencies"
71-
MIN_FREQ=$(cat $CPUFREQ_PATH/cpuinfo_min_freq)
72-
MAX_FREQ=$(cat $CPUFREQ_PATH/cpuinfo_max_freq)
71+
MIN_FREQ=$(cat "$CPUFREQ_PATH"/cpuinfo_min_freq)
72+
MAX_FREQ=$(cat "$CPUFREQ_PATH"/cpuinfo_max_freq)
7373
log_info "CPU frequency range: $MIN_FREQ - $MAX_FREQ"
7474

7575
log_info "Triggering frequency update via governor"
7676
dd if=/dev/urandom of=/dev/null bs=1M count=1000 &
7777
LOAD_PID=$!
7878
sleep 2
7979

80-
CURRENT_FREQ=$(cat $CPUFREQ_PATH/scaling_cur_freq)
80+
CURRENT_FREQ=$(cat "$CPUFREQ_PATH"/scaling_cur_freq)
8181
log_info "Observed frequency under load: $CURRENT_FREQ"
8282

8383
kill $LOAD_PID
@@ -91,5 +91,3 @@ else
9191
echo "$TESTNAME FAIL" > "$res_file"
9292
exit 1
9393
fi
94-
95-
log_info "----------- Completed $TESTNAME Test ------------"

0 commit comments

Comments
 (0)