rebased lib_gstreamer.sh and added changes, modified the display and video scripts based on review comments

Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com>

Author: nitinn22

Runner/suites/Multimedia/GSTreamer/Display/Waylandsink_Playback/README.md

@@ -73,10 +73,11 @@ The script is designed to be **CI/LAVA-friendly**:
 
 ### Options
 
-- `--duration <seconds>` - Playback duration (default: 10)
+- `--resolution <WIDTHxHEIGHT>` - Video resolution (e.g., 1920x1080, 3840x2160) (default: 1920x1080)
+- `--duration <seconds>` - Playback duration (default: 30)
 - `--pattern <smpte|snow|ball|etc>` - videotestsrc pattern (default: smpte)
-- `--width <pixels>` - Video width (default: 1920)
-- `--height <pixels>` - Video height (default: 1080)
+- `--width <pixels>` - Video width (alternative to --resolution) (default: 1920)
+- `--height <pixels>` - Video height (alternative to --resolution) (default: 1080)
 - `--framerate <fps>` - Video framerate (default: 30)
 - `--gst-debug <level>` - GStreamer debug level 1-9 (default: 2)
 
@@ -88,14 +89,23 @@ The script is designed to be **CI/LAVA-friendly**:
 # Run default test (1920x1080 SMPTE for 30s)
 ./run.sh
 
-# Run with 30 second duration
-./run.sh --duration 30
+# Run with custom resolution using --resolution
+./run.sh --resolution 3840x2160
+
+# Run with custom resolution and duration
+./run.sh --resolution 3840x2160 --duration 20
 
 # Run with ball pattern
 ./run.sh --pattern ball
 
-# Run with custom resolution
+# Run with custom resolution using separate width/height
 ./run.sh --width 1280 --height 720
+
+# Run with different framerate
+./run.sh --framerate 60
+
+# Run with higher debug level
+./run.sh --gst-debug 5
 ```
 
 ---
@@ -146,10 +156,15 @@ videotestsrc num-buffers=<N> pattern=<pattern>
 
 ## LAVA Environment Variables
 
-- `VIDEO_DURATION` - Playback duration
-- `VIDEO_PATTERN` - videotestsrc pattern
-- `VIDEO_WIDTH` - Video width
-- `VIDEO_HEIGHT` - Video height
-- `VIDEO_FRAMERATE` - Video framerate
-- `VIDEO_GST_DEBUG` - GStreamer debug level
+The test supports these environment variables (can be set in LAVA job definition):
+
+- `VIDEO_DURATION` - Playback duration in seconds (default: 30)
 - `RUNTIMESEC` - Alternative to VIDEO_DURATION
+- `VIDEO_PATTERN` - videotestsrc pattern (default: smpte)
+- `VIDEO_WIDTH` - Video width (default: 1920)
+- `VIDEO_HEIGHT` - Video height (default: 1080)
+- `VIDEO_FRAMERATE` - Video framerate (default: 30)
+- `VIDEO_GST_DEBUG` - GStreamer debug level (default: 2)
+- `GST_DEBUG_LEVEL` - Alternative to VIDEO_GST_DEBUG
+
+**Priority order for duration**: `VIDEO_DURATION` > `RUNTIMESEC` > default (30)

Runner/suites/Multimedia/GSTreamer/Display/Waylandsink_Playback/Waylandsink_Playback.yaml

@@ -12,20 +12,27 @@ metadata:
     - functional
 
 params:
-  # Video resolution (WIDTHxHEIGHT)
-  VIDEO_RESOLUTION: "1920x1080"
+  # Playback duration in seconds (default: 30)
+  # Priority: VIDEO_DURATION > RUNTIMESEC
+  VIDEO_DURATION: "30"
+  RUNTIMESEC: "" # if set, used as fallback
 
-  # Test pattern for videotestsrc
-  VIDEO_PATTERN: "smpte" # smpte|snow|black|white|red|green|blue|checkers-1|checkers-2
+  # Test pattern for videotestsrc (default: smpte)
+  VIDEO_PATTERN: "smpte" # smpte|snow|black|white|red|green|blue|checkers-1|checkers-2|ball
 
-  # Playback duration in seconds
-  PLAYBACK_DURATION: "30"
+  # Video width in pixels (default: 1920)
+  VIDEO_WIDTH: "1920"
 
-  # Frame rate
-  FRAMERATE: "30"
+  # Video height in pixels (default: 1080)
+  VIDEO_HEIGHT: "1080"
 
-  # GStreamer debug level
+  # Frame rate (default: 30)
+  VIDEO_FRAMERATE: "30"
+  
+  # GStreamer debug level (default: 2)
+  # Priority: VIDEO_GST_DEBUG > GST_DEBUG_LEVEL
   VIDEO_GST_DEBUG: "2" # 1-9
+  GST_DEBUG_LEVEL: "" # if set, used as fallback
 
 run:
   steps:
@@ -34,14 +41,26 @@ run:
     # Navigate to test directory
     - cd Runner/suites/Multimedia/GSTreamer/Display/Waylandsink_Playback/
 
-    # Build CLI args only when params are non-empty
+    # Export environment variables (script reads these directly)
+    - export VIDEO_DURATION="${VIDEO_DURATION}"
+    - export RUNTIMESEC="${RUNTIMESEC}"
+    - export VIDEO_PATTERN="${VIDEO_PATTERN}"
+    - export VIDEO_WIDTH="${VIDEO_WIDTH}"
+    - export VIDEO_HEIGHT="${VIDEO_HEIGHT}"
+    - export VIDEO_FRAMERATE="${VIDEO_FRAMERATE}"
+    - export VIDEO_GST_DEBUG="${VIDEO_GST_DEBUG}"
+    - export GST_DEBUG_LEVEL="${GST_DEBUG_LEVEL}"
+
+    # Build CLI args for overrides (optional - can also rely on env vars)
     - |
       CMD="./run.sh"
 
-      [ -n "${VIDEO_RESOLUTION}" ] && CMD="${CMD} --resolution ${VIDEO_RESOLUTION}"
+      # Use CLI args to override defaults if needed
+      # Note: Script reads env vars by default, CLI args override env vars
+      [ -n "${VIDEO_WIDTH}" ] && [ -n "${VIDEO_HEIGHT}" ] && CMD="${CMD} --resolution ${VIDEO_WIDTH}x${VIDEO_HEIGHT}"
       [ -n "${VIDEO_PATTERN}" ] && CMD="${CMD} --pattern ${VIDEO_PATTERN}"
-      [ -n "${PLAYBACK_DURATION}" ] && CMD="${CMD} --duration ${PLAYBACK_DURATION}"
-      [ -n "${FRAMERATE}" ] && CMD="${CMD} --framerate ${FRAMERATE}"
+      [ -n "${VIDEO_DURATION}" ] && CMD="${CMD} --duration ${VIDEO_DURATION}"
+      [ -n "${VIDEO_FRAMERATE}" ] && CMD="${CMD} --framerate ${VIDEO_FRAMERATE}"
       [ -n "${VIDEO_GST_DEBUG}" ] && CMD="${CMD} --gst-debug ${VIDEO_GST_DEBUG}"
 
       echo "[LAVA] Running: ${CMD}"