Skip to content

Commit 2fde3ea

Browse files
committed
Libcamera_cam printed artifact locations after the final PASS/FAIL exit
path, making that block unreachable and triggering ShellCheck SC2317. Move the artifact summary logging above the final verdict so the logs are actually emitted while preserving the existing PASS/FAIL behavior and result-file flow. Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
1 parent 4e0f86b commit 2fde3ea

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

  • Runner/suites/Multimedia/Camera/Libcamera_cam

Runner/suites/Multimedia/Camera/Libcamera_cam/run.sh

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -284,6 +284,13 @@ else
284284
fi
285285
log_info "Summary file: $OUT_DIR/summary.txt"
286286

287+
# ---------- Artifacts ----------
288+
log_info "Artifacts under: $OUT_DIR/"
289+
for IDX in $INDICES; do
290+
CAM_DIR="${OUT_DIR%/}/cam${IDX}"
291+
log_info " - $CAM_DIR/"
292+
done
293+
287294
# ---------- Final verdict ----------
288295
if [ "$OVERALL_PASS" -eq 1 ] && [ $ANY_RC_NONZERO -eq 0 ]; then
289296
echo "$TESTNAME PASS" > "$RES_FILE"
@@ -294,10 +301,3 @@ else
294301
log_fail "$TESTNAME FAIL"
295302
exit 1
296303
fi
297-
298-
# ---------- Artifacts ----------
299-
log_info "Artifacts under: $OUT_DIR/"
300-
for IDX in $INDICES; do
301-
CAM_DIR="${OUT_DIR%/}/cam${IDX}"
302-
log_info " - $CAM_DIR/"
303-
done

0 commit comments

Comments
 (0)