Merge pull request #357 from smuppand/Bluetooth-fix

shellcheck: reduce false positives in Bluetooth scripts

Author: vnarapar

Runner/suites/Connectivity/Bluetooth/BT_SCAN_PAIR/run.sh

@@ -1,5 +1,4 @@
 #!/bin/sh
-
 # Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
 # SPDX-License-Identifier: BSD-3-Clause
 # Robustly find and source init_env
@@ -107,6 +106,7 @@ check_dependencies bluetoothctl rfkill expect hciconfig || {
     exit 0
 }
 
+# shellcheck disable=SC2317  # cleanup is invoked via trap
 cleanup_bt_test() {
     # Cleanup only the primary MAC we worked with (if any)
     [ -n "$BT_MAC" ] && bt_cleanup_paired_device "$BT_MAC"

Runner/utils/lib_bluetooth.sh

@@ -85,25 +85,6 @@ retry_command_bt() {
     return 1
 }
 
-# Check if a device (MAC or Name) is in the whitelist
-bt_in_whitelist() {
-    device_name="$1"
-    device_mac="$2"
-
-    whitelist_value="${WHITELIST:-}"
-    log_info "Checking if MAC='$device_mac' or NAME='$device_name' is in whitelist: '$whitelist_value'"
-
-    echo "$whitelist_value" | tr -s ' ' '\n' | while IFS= read -r allowed; do
-        if [ "$allowed" = "$device_mac" ] || [ "$allowed" = "$device_name" ]; then
-            log_info "MAC or NAME matched and allowed: $allowed"
-            return 0
-        fi
-    done
-
-    log_info "MAC matched but neither MAC nor NAME in whitelist"
-    return 1
-}
-
 # bt_parse_whitelist <whitelist_file>
 # Reads a whitelist file where each line has:
 bt_parse_whitelist() {